Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 9487011: Generate ETW events in Chrome Frame under the control of the same env var as Chrome. (Closed)

Created:
8 years, 9 months ago by grt (UTC plus 2)
Modified:
8 years, 9 months ago
Reviewers:
robertshield
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Generate ETW events in Chrome Frame under the control of the same env var as Chrome. CHROME_ETW_LOGGING env var now controls whether or not npchrome_frame.dll generates ETW events. This matches the behavior in chrome.exe. I also tweaked the log settings so that the same info is included in npchrome_frame.dll log messages as those in chrome.exe. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome_frame/chrome_tab.cc View 4 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
grt (UTC plus 2)
8 years, 9 months ago (2012-02-28 15:47:59 UTC) #1
grt (UTC plus 2)
ping
8 years, 9 months ago (2012-03-01 15:16:39 UTC) #2
robertshield
lgtm, apologies for the delay.
8 years, 9 months ago (2012-03-01 15:18:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/9487011/1
8 years, 9 months ago (2012-03-01 16:14:30 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 17:58:06 UTC) #5
Change committed as 124427

Powered by Google App Engine
This is Rietveld 408576698