Issue 9483002: Move values_test_util.{h,cc} to base/test

Issue 9483002: Move values_test_util.{h,cc} to base/test (Closed)

Created:
8 years, 10 months ago by akalin

Modified:
8 years, 9 months ago

Reviewers:
darin (slow to review), Nicolas Zea

CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move values_test_util.{h,cc} to base/test This removes a dependency from sync stuff to chrome/common stuff. test utility functions should belong with their corresponding classes anyway. BUG=113723 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124112

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -165 lines)			Patch
M	base/base.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	base/test/values_test_util.h	View		2 chunks	+13 lines, -16 lines	0 comments	Download
A +	base/test/values_test_util.cc	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/internal_api/change_record_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/internal_api/syncapi_unittest.cc	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/sessions/session_state_unittest.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/syncable/model_type_payload_map_unittest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/syncable/model_type_unittest.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable_id_unittest.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable_unittest.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/net/gaia/google_service_auth_error_unittest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
D	chrome/test/base/values_test_util.h	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/test/base/values_test_util.cc	View		1 chunk	+0 lines, -62 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

sync LGTM http://codereview.chromium.org/9483002/diff/1/chrome/browser/sync/internal_api/syncapi_unittest.cc File chrome/browser/sync/internal_api/syncapi_unittest.cc (right): http://codereview.chromium.org/9483002/diff/1/chrome/browser/sync/internal_api/syncapi_unittest.cc#newcode93 chrome/browser/sync/internal_api/syncapi_unittest.cc:93: using base::ExpectDictStringValue; move to first spot in ...

8 years, 10 months ago (2012-02-28 02:18:56 UTC) #2

akalin

Darin, ping? http://codereview.chromium.org/9483002/diff/1/chrome/browser/sync/internal_api/syncapi_unittest.cc File chrome/browser/sync/internal_api/syncapi_unittest.cc (right): http://codereview.chromium.org/9483002/diff/1/chrome/browser/sync/internal_api/syncapi_unittest.cc#newcode93 chrome/browser/sync/internal_api/syncapi_unittest.cc:93: using base::ExpectDictStringValue; On 2012/02/28 02:18:56, nzea wrote: ...

8 years, 9 months ago (2012-02-28 22:59:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9483002/8001

8 years, 9 months ago (2012-02-29 01:03:04 UTC) #5

Change committed as 124112

Expand Messages | Collapse Messages