Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 9481021: Increase line-height to 38px and decrease column headers by 1 px in file manager (Closed)

Created:
8 years, 10 months ago by bshe
Modified:
8 years, 9 months ago
Reviewers:
rginda, flackr
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Increase line-height to 38px and decrease column headers by 1 px in file manager BUG=chromium-os:25932, chromium-os:25934 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124133

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
bshe
Hi Rob. Could you please take a look at this minor UI tweaks? It follows ...
8 years, 10 months ago (2012-02-28 01:38:17 UTC) #1
rginda
lgtm
8 years, 9 months ago (2012-02-28 18:07:33 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-02-28 18:31:44 UTC) #3
rginda
Dude, I'm totally a superstar.
8 years, 9 months ago (2012-02-28 18:40:54 UTC) #4
bshe
On 2012/02/28 18:40:54, rginda wrote: > Dude, I'm totally a superstar. :) Thats what I ...
8 years, 9 months ago (2012-02-28 18:42:47 UTC) #5
bshe
+flackr "another" full super star committer
8 years, 9 months ago (2012-02-28 20:22:07 UTC) #6
flackr
http://codereview.chromium.org/9481021/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): http://codereview.chromium.org/9481021/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode696 chrome/browser/resources/file_manager/css/file_manager.css:696: height: 28px; Doesn't this need to be updated as ...
8 years, 9 months ago (2012-02-28 20:27:02 UTC) #7
bshe
Done. Thanks! http://codereview.chromium.org/9481021/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): http://codereview.chromium.org/9481021/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode696 chrome/browser/resources/file_manager/css/file_manager.css:696: height: 28px; On 2012/02/28 20:27:02, flackr wrote: ...
8 years, 9 months ago (2012-02-28 20:51:54 UTC) #8
flackr
lgtm
8 years, 9 months ago (2012-02-28 20:55:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/9481021/8002
8 years, 9 months ago (2012-02-28 21:21:03 UTC) #10
commit-bot: I haz the power
Try job failure for 9481021-8002 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-02-28 22:45:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/9481021/8002
8 years, 9 months ago (2012-02-29 03:34:24 UTC) #12
commit-bot: I haz the power
8 years, 9 months ago (2012-02-29 06:03:17 UTC) #13
Change committed as 124133

Powered by Google App Engine
This is Rietveld 408576698