Remove the "set noparent" from the chrome\browser\ui subdirectories. This is causing a lot of pain …

chrome/browser/ui/cocoa/OWNERS

-set noparent

[Mark Mentovai, 2012/02/27 19:57:06]

As I mentioned earlier, the reason we have this set to “noparent” is to make up
for the inability to enforce Objective-C readability project-wide. Before we
added this, we saw a good number of changes being made in this directory that
ought never have been made because the author had a poor grasp of the language.
I think it should be rare enough to see a refactoring in this directory that
doesn’t touch anything Objective, but “make refactoring easier” is the only
reason proffered for this change. On the other hand, I don’t see the need for
Ben or Scott to have to refer someone to a cocoa OWNER manually and on a
case-by-case basis for the more common occurrences involving substantive
changes.

[jam, 2012/02/27 20:02:57]

I agree changes were misreviewed before you added this. I think that was because
there was NO owners checks at that time, since chrome\browser\ui didn't have
"set no parent", so effectively this OWNERS file was ignored. sesek added this
"set noparent" in Dec 20. Ben added the "set noparent" to the above directory
after that, on Jan 20.
I've hit this myself many times, and so have others I've talked to. Even if it
is rare, we want to be in a world where this no acceptable reason to ignore
OWNERS (i.e. what google3 enforces).
People touching code in ui/cocoa shouldn't be sending the change to ben/scott
initially. Just like in google3 no one will send a toplevel owner a change for
review that only touches a subdir with its own OWNERS file.

The reason to remove "set noparent" is simply for project wide refactorings, and
that's the only time that ben/scott will ok changes in subdirs.

 asvitkine@chromium.org
 avi@chromium.org
 dhollowa@chromium.org
 dmaclach@chromium.org
 isherman@chromium.org
 jeremy@chromium.org
 mark@chromium.org
 mirandac@chromium.org
 mrossetti@chromium.org
 pinkerton@chromium.org
 rohitrao@chromium.org
 rsesek@chromium.org
 sail@chromium.org
 shess@chromium.org
 stuartmorgan@chromium.org
 thakis@chromium.org
 thomasvl@chromium.org
 viettrungluu@chromium.org