Added ScopedPrinterHandle

Added ScopedPrinterHandle

TEST=it compiles
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124640

[Vitaly Buka (NO REVIEWS), 2012-02-28 09:30:14]

Please review.

[brettw, 2012-02-28 19:14:26]

lgtm

[commit-bot: I haz the power, 2012-03-01 19:05:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9480026/10001

[commit-bot: I haz the power, 2012-03-01 19:05:48]

Presubmit check for 9480026-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: printing/backend/win_helper.h

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-03-01 19:06:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9480026/10001

[commit-bot: I haz the power, 2012-03-01 19:06:22]

Presubmit check for 9480026-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: printing/backend/win_helper.h

[gene, 2012-03-01 19:28:54]

lgtm for printing

[commit-bot: I haz the power, 2012-03-01 19:29:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9480026/10001

[commit-bot: I haz the power, 2012-03-01 19:50:28]

Try job failure for 9480026-10001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[alexeypa (please no reviews), 2012-03-01 21:37:43]

LGTM, but please check my comments out.

http://codereview.chromium.org/9480026/diff/17004/base/win/scoped_handle.h
File base/win/scoped_handle.h (right):

http://codereview.chromium.org/9480026/diff/17004/base/win/scoped_handle.h#ne...
base/win/scoped_handle.h:34: class GenericScopedHandle {
Consider implementing it as

template <class T, class Traits>
class GenericScopedHandle {...};

where T is the raw handle type. This will require abstracting NULL handle
concept via Traits.

http://codereview.chromium.org/9480026/diff/17004/base/win/scoped_handle.h#ne...
base/win/scoped_handle.h:93: class DefaultHandleTraits {
Consider renaming it to HandleTraits. It is in a Windows-specific namespace
already, were "handle" means HANDLE. (Win32 HANDLE actually). Other types of
handles usually have some prefix in the name.

[Vitaly Buka (NO REVIEWS), 2012-03-01 22:14:42]

http://codereview.chromium.org/9480026/diff/17004/base/win/scoped_handle.h
File base/win/scoped_handle.h (right):

http://codereview.chromium.org/9480026/diff/17004/base/win/scoped_handle.h#ne...
base/win/scoped_handle.h:34: class GenericScopedHandle {
I thought about that. But I'd like to add feature when it needed.

On 2012/03/01 21:37:43, alexeypa wrote:
> Consider implementing it as
> 
> template <class T, class Traits>
> class GenericScopedHandle {...};
> 
> where T is the raw handle type. This will require abstracting NULL handle
> concept via Traits.

http://codereview.chromium.org/9480026/diff/17004/base/win/scoped_handle.h#ne...
base/win/scoped_handle.h:93: class DefaultHandleTraits {
On 2012/03/01 21:37:43, alexeypa wrote:
> Consider renaming it to HandleTraits. It is in a Windows-specific namespace
> already, were "handle" means HANDLE. (Win32 HANDLE actually). Other types of
> handles usually have some prefix in the name.

Done.

[Wez, 2012-03-01 23:24:09]

lgtm

[commit-bot: I haz the power, 2012-03-01 23:24:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9480026/15009

[commit-bot: I haz the power, 2012-03-02 02:59:51]

Try job failure for 9480026-15009 (retry) on win_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-02 04:00:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9480026/15009

[commit-bot: I haz the power, 2012-03-02 15:00:59]

Change committed as 124640