Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 9480005: Convert ErrorExit() calls back into an HTTPError exception so it can be properly handled. (Closed)

Created:
8 years, 10 months ago by M-A Ruel
Modified:
8 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Convert ErrorExit() calls back into an HTTPError exception so it can be properly handled. Occasionally, AppEngine throws HTTP 500. In practice it's not a big deal but upload.py converts them into sys.exit() call which is problematic. This breaks the commit queue since this behaviors forces the CQ to quit. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M rietveld.py View 1 chunk +37 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
8 years, 10 months ago (2012-02-27 16:31:17 UTC) #1
Dirk Pranke
lgtm
8 years, 9 months ago (2012-02-27 19:02:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9480005/1
8 years, 9 months ago (2012-02-27 19:04:42 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-02-27 19:11:16 UTC) #4
Change committed as 123775

Powered by Google App Engine
This is Rietveld 408576698