Support named ctors.

client/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 261 matching lines @@
       self._cpp_declarations_emitter.Emit(
           '\n'
           'void constructorCallback(Dart_NativeArguments);\n')
       return
 
     raises_dom_exceptions = 'ConstructorRaisesException' in self._interface.ext_attrs
     raises_dart_exceptions = raises_dom_exceptions or len(constructor_info.idl_args) > 0
     type_info = GetIDLTypeInfo(self._interface)
     arguments = []
     parameter_definitions_emitter = emitter.Emitter()
+    create_function = 'create'
+    if 'NamedConstructor' in self._interface.ext_attrs:
+      raises_dart_exceptions = True
+      parameter_definitions_emitter.Emit(
+            '        DOMWindow* domWindow = DartUtilities::domWindowForCurrentIsolate();\n'
+            '        if (!domWindow) {\n'
+            '            exception = Dart_NewString("Failed to fetch domWindow");\n'
+            '            goto fail;\n'
+            '        }\n'
+            '        Document* document = domWindow->document();\n')

[podivilov, 2012/02/27 15:53:48]

Our constructors seems to be very simple comparing to CodeGeneratorV8 ones.
Could you please compare implementations and add fixmes? E.g. add document to
DOM map to ensure that newly created node won't be collected prematurely (even
if we don't support grouping yet).

[antonm, 2012/02/27 15:59:36]

I am not sure.  For example, I am not sure they really need to wrap document in
v8---object grouping should work in any case.

On 2012/02/27 15:53:48, podivilov wrote:

+      arguments.append('document')
+      create_function = 'createForJSConstructor'
     if 'CallWith' in self._interface.ext_attrs:
       call_with = self._interface.ext_attrs['CallWith']
       if call_with == 'ScriptExecutionContext':
         raises_dart_exceptions = True
         parameter_definitions_emitter.Emit(
             '        ScriptExecutionContext* context = DartUtilities::scriptExecutionContext();\n'
             '        if (!context) {\n'
             '            exception = Dart_NewString("Failed to create an object");\n'
             '            goto fail;\n'
             '        }\n')
         arguments.append('context')
       else:
         raise Exception('Unsupported CallWith=%s attribute' % call_with)
 
     # Process constructor arguments.
     for (i, arg) in enumerate(constructor_info.idl_args):
       self._GenerateParameterAdapter(parameter_definitions_emitter, arg, i - 1)
       arguments.append(arg.id)
 
     self._GenerateNativeCallback(
         callback_name='constructorCallback',
         idl_node=self._interface,
         parameter_definitions=parameter_definitions_emitter.Fragments(),
-        needs_receiver=False, function_name='%s::create' % type_info.native_type(),
+        needs_receiver=False, function_name='%s::%s' % (type_info.native_type(), create_function),
         arguments=arguments,
         idl_return_type=self._interface,
         raises_dart_exceptions=raises_dart_exceptions,
         raises_dom_exceptions=raises_dom_exceptions)
 
 
   def _ImplClassName(self, interface_name):
     return interface_name + 'Implementation'
 
   def _IsConstructable(self):
     # FIXME: support ConstructorTemplate.
-    # FIXME: support NamedConstructor.
-    return set(['CustomConstructor', 'V8CustomConstructor', 'Constructor']) & set(self._interface.ext_attrs)
+    return set(['CustomConstructor', 'V8CustomConstructor', 'Constructor', 'NamedConstructor']) & set(self._interface.ext_attrs)
 
   def FinishInterface(self):
     base = self._BaseClassName(self._interface)
     self._dart_impl_emitter.Emit(
         self._templates.Load('dart_implementation.darttemplate'),
         CLASS=self._class_name, BASE=base, INTERFACE=self._interface.id,
         MEMBERS=self._members_emitter.Fragments())
 
     self._GenerateCppHeader()
 
@@ skipping 400 matching lines @@
       callback = emitter.Format(template, **template_parameters)
 
     self._cpp_definitions_emitter.Emit(callback)
 
   def _GenerateParameterAdapter(self, emitter, idl_argument, index):
     type_info = GetIDLTypeInfo(idl_argument.type)
     (adapter_type, include_name) = type_info.parameter_adapter_info()
     if include_name:
       self._cpp_impl_includes[include_name] = 1
     flags = ''
-    if idl_argument.ext_attrs.get('Optionial') == 'DefaultIsNullString':
+    if idl_argument.ext_attrs.get('Optional') == 'DefaultIsNullString':

[podivilov, 2012/02/27 15:53:48]

This code is not actually used, do we really want to keep it?

[antonm, 2012/02/27 15:59:36]

Why it's not used?  It's need, e.g., to make (most probably slightly incorrect)
test to pass

[podivilov, 2012/02/27 16:59:49]

Ok, seems like it is used for constructor parameters.

       flags = ', DartUtilities::ConvertNullToEmptyString'
     emitter.Emit(
         '\n'
         '        const $ADAPTER_TYPE $NAME(Dart_GetNativeArgument(args, $INDEX)$FLAGS);\n'
         '        if (!$NAME.conversionSuccessful()) {\n'
         '            exception = $NAME.exception();\n'
         '            goto fail;\n'
         '        }\n',
         ADAPTER_TYPE=adapter_type,
         NAME=idl_argument.id,
@@ skipping 29 matching lines @@
     namespace = 'HTMLNames'
     svg_exceptions = ['class', 'id', 'onabort', 'onclick', 'onerror', 'onload',
                       'onmousedown', 'onmousemove', 'onmouseout', 'onmouseover',
                       'onmouseup', 'onresize', 'onscroll', 'onunload']
     if self._interface.id.startswith('SVG') and not attr.id in svg_exceptions:
       namespace = 'SVGNames'
     self._cpp_impl_includes[namespace] = 1
 
     attribute_name = attr.ext_attrs['Reflect'] or attr.id.lower()
     return 'WebCore::%s::%sAttr' % (namespace, attribute_name)