Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5177)

Unified Diff: chrome/browser/ui/views/reload_button.cc

Issue 9479008: Re-factor location bar/toolbar code to get rid of the browser dependency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: call right overloaded method Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/reload_button.h ('k') | chrome/browser/ui/views/toolbar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/reload_button.cc
diff --git a/chrome/browser/ui/views/reload_button.cc b/chrome/browser/ui/views/reload_button.cc
index 34b78578346280a6028103087eef05c571136dc6..8c0309eb4dc9870a83f6585e4245ce8c96237d68 100644
--- a/chrome/browser/ui/views/reload_button.cc
+++ b/chrome/browser/ui/views/reload_button.cc
@@ -6,7 +6,7 @@
#include "base/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
-#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/command_updater.h"
#include "chrome/browser/ui/views/event_utils.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
#include "grit/generated_resources.h"
@@ -19,10 +19,11 @@ const char ReloadButton::kViewClassName[] = "browser/ui/views/ReloadButton";
////////////////////////////////////////////////////////////////////////////////
// ReloadButton, public:
-ReloadButton::ReloadButton(LocationBarView* location_bar, Browser* browser)
+ReloadButton::ReloadButton(LocationBarView* location_bar,
+ CommandUpdater* command_updater)
: ALLOW_THIS_IN_INITIALIZER_LIST(ToggleImageButton(this)),
location_bar_(location_bar),
- browser_(browser),
+ command_updater_(command_updater),
intended_mode_(MODE_RELOAD),
visible_mode_(MODE_RELOAD),
double_click_timer_delay_(
@@ -72,16 +73,14 @@ void ReloadButton::ChangeMode(Mode mode, bool force) {
void ReloadButton::ButtonPressed(views::Button* /* button */,
const views::Event& event) {
if (visible_mode_ == MODE_STOP) {
- if (browser_)
- browser_->Stop();
+ if (command_updater_)
+ command_updater_->ExecuteCommandWithDisposition(IDC_STOP, CURRENT_TAB);
// The user has clicked, so we can feel free to update the button,
// even if the mouse is still hovering.
ChangeMode(MODE_RELOAD, true);
} else if (!double_click_timer_.IsRunning()) {
// Shift-clicking or ctrl-clicking the reload button means we should ignore
// any cached content.
- // TODO(avayvod): eliminate duplication of this logic in
- // CompactLocationBarView.
int command;
int flags = mouse_event_flags();
if (event.IsShiftDown() || event.IsControlDown()) {
@@ -109,8 +108,8 @@ void ReloadButton::ButtonPressed(views::Button* /* button */,
double_click_timer_.Start(FROM_HERE, double_click_timer_delay_, this,
&ReloadButton::OnDoubleClickTimer);
- if (browser_)
- browser_->ExecuteCommandWithDisposition(command, disposition);
+ if (command_updater_)
+ command_updater_->ExecuteCommandWithDisposition(command, disposition);
++testing_reload_count_;
}
}
« no previous file with comments | « chrome/browser/ui/views/reload_button.h ('k') | chrome/browser/ui/views/toolbar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698