Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: chrome/browser/command_updater.h

Issue 9479008: Re-factor location bar/toolbar code to get rid of the browser dependency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: call right overloaded method Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/command_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/command_updater.h
diff --git a/chrome/browser/command_updater.h b/chrome/browser/command_updater.h
index 024658d7a2b90c156767c4b67de36a663c420efd..86600730fb7f1f046eb2a3766953c0bed7213c06 100644
--- a/chrome/browser/command_updater.h
+++ b/chrome/browser/command_updater.h
@@ -8,6 +8,7 @@
#include "base/basictypes.h"
#include "base/hash_tables.h"
+#include "webkit/glue/window_open_disposition.h"
////////////////////////////////////////////////////////////////////////////////
//
@@ -23,8 +24,11 @@ class CommandUpdater {
// when needed.
class CommandUpdaterDelegate {
public:
- // Perform the action associated with the command with the specified ID.
- virtual void ExecuteCommand(int id) = 0;
+ // Performs the action associated with the command with the specified ID and
+ // using the given disposition.
+ virtual void ExecuteCommandWithDisposition(
+ int id,
+ WindowOpenDisposition disposition) = 0;
protected:
virtual ~CommandUpdaterDelegate();
@@ -42,11 +46,19 @@ class CommandUpdater {
// supported by this updater.
bool IsCommandEnabled(int id) const;
- // Performs the action associated with this command ID.
+ // Performs the action associated with this command ID using CURRENT_TAB
+ // disposition.
// TODO(beng): get rid of this since it's effectively just a pass-thru and the
// call sites would be better off using more well defined delegate interfaces.
void ExecuteCommand(int id);
+ // Performs the action associated with this command ID using the given
+ // disposition.
+ // TODO(altimofeev): refactor the interface to provide more flexible and
+ // explicit way for passing command specific arguments. See
+ // NotificationDetails class for the possible implementation ideas.
+ void ExecuteCommandWithDisposition(int id, WindowOpenDisposition disposition);
+
// An Observer interface implemented by objects that want to be informed when
// the state of a particular command ID is modified.
class CommandObserver {
« no previous file with comments | « no previous file | chrome/browser/command_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698