Re-factor location bar/toolbar code to get rid of the browser dependency.

chrome/browser/command_updater.h

Index: chrome/browser/command_updater.h
diff --git a/chrome/browser/command_updater.h b/chrome/browser/command_updater.h
index 024658d7a2b90c156767c4b67de36a663c420efd..880caf8de4755f779bcd93356d84ca2cb98fc4a0 100644
--- a/chrome/browser/command_updater.h
+++ b/chrome/browser/command_updater.h
@@ -8,6 +8,7 @@
 
 #include "base/basictypes.h"
 #include "base/hash_tables.h"
+#include "webkit/glue/window_open_disposition.h"
 
 ////////////////////////////////////////////////////////////////////////////////
 //
@@ -23,8 +24,11 @@ class CommandUpdater {
   // when needed.
   class CommandUpdaterDelegate {
    public:
-    // Perform the action associated with the command with the specified ID.
-    virtual void ExecuteCommand(int id) = 0;
+    // Performs the action associated with the command with the specified ID and
+    // using the given disposition.
+    virtual void ExecuteCommandWithDisposition(
+        int id,
+        WindowOpenDisposition disposition) = 0;

[sky, 2012/03/12 15:14:05]

It doesn't scale to add a new argument to this interface. Could you instead have
the reload button push the window open disposition to the LocationBar and have
reload get the disposition from the locationbar? This is similar to how
OpenCurrentURL works.

[altimofeev, 2012/03/12 15:38:42]

I'm not agree with you:
1. Having disposition as an argument is logically consistent, because Browser,
which is the only CommmandUpdaterDelegate's successor, always calls
ExecuteCommandWithDisposition.
2. No obvious reason, why this interface will need a new argument.
3. OpenCurrentURL's solution looks like a hack for me: method
GetWindowOpenDisposition doesn't look like related to LocationBar, because
WindowOpenDisposition is event's property, not UI's.
4. Furthermore, OpenCurrentURL hack only confirms, that CommandUpdater interface
should be changed.

What am I missing?

 
    protected:
     virtual ~CommandUpdaterDelegate();
@@ -42,11 +46,16 @@ class CommandUpdater {
   // supported by this updater.
   bool IsCommandEnabled(int id) const;
 
-  // Performs the action associated with this command ID.
+  // Performs the action associated with this command ID using CURRENT_TAB
+  // disposition.
   // TODO(beng): get rid of this since it's effectively just a pass-thru and the
   // call sites would be better off using more well defined delegate interfaces.
   void ExecuteCommand(int id);
 
+  // Performs the action associated with this command ID using the given
+  // disposition.
+  void ExecuteCommandWithDisposition(int id, WindowOpenDisposition disposition);
+
   // An Observer interface implemented by objects that want to be informed when
   // the state of a particular command ID is modified.
   class CommandObserver {