Aura: Build on the linux desktop, plus add USE_ASH.

Aura: Build on the linux desktop, plus add USE_ASH.

BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124488

[Elliot Glaysher, 2012-02-28 18:13:32]

1) bug#?

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/auto...
File chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
(right):

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/auto...
chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc:355:
ash::WINDOW_VISIBILITY_ANIMATION_TYPE_VERTICAL);
This doesn't look as good without upstreaming the window visibility stuff here.
It defaults to a zoomfade in/out, when a vertical fade/slide up looks better.

[Ben Goodger (Google), 2012-02-28 20:12:06]

http://codereview.chromium.org/9478015/diff/4002/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/9478015/diff/4002/build/common.gypi#newcode355
build/common.gypi:355: ['chromeos==1 or use_aura==1', {
change this to just be chromeos==1

http://codereview.chromium.org/9478015/diff/4002/build/common.gypi#newcode362
build/common.gypi:362: ['use_aura==1 and (OS=="win" or (OS=="linux" and
chromeos==0))', {
and then discard this whole block.

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/sele...
File chrome/browser/ui/views/select_file_dialog_aura.cc (right):

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/sele...
chrome/browser/ui/views/select_file_dialog_aura.cc:16: return new
SelectFaileDialogExtension(listener);
SelectFileDialogExtension

(this won't compile as-is)

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/tab_...
File chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc
(right):

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:65:
aura::Window::ConvertPointToWindow(ash::Shell::GetRootWindow(),
if you rewrite this slightly, replacing ash::Shell::GetRootWindow() with
window->GetRootWindow(), this whole block will build and run on vanilla Aura.

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:226: #if
defined(USE_ASH)
I don't see why this is Ash-specific?

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:305:
gfx::Point screen_pt = ash::Shell::GetRootWindow()->last_mouse_location();
replace ash::Shell::GetRootWindow() with:

GetNativeView()->GetRootWindow()

and this will build

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:317:
gfx::Point screen_pt = ash::Shell::GetRootWindow()->last_mouse_location();
same here

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:335:
event.location(), ash::Shell::GetRootWindow()->last_mouse_location());
and here

http://codereview.chromium.org/9478015/diff/4002/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:349:
ash::Shell::GetRootWindow()->last_mouse_location();
and here

[Elliot Glaysher, 2012-02-28 20:35:54]

Did all the GetRootWindow() changes too.

http://codereview.chromium.org/9478015/diff/4002/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/9478015/diff/4002/build/common.gypi#newcode355
build/common.gypi:355: ['chromeos==1 or use_aura==1', {
On 2012/02/28 20:12:06, Ben Goodger (Google) wrote:
> change this to just be chromeos==1

Done.

[Ben Goodger (Google), 2012-02-28 20:37:31]

LGTM, but you'll have to make the infra changes first before you can land this,
otherwise you'll have to find a way to have USE_ASH be set by USE_AURA until
that happens.

[Elliot Glaysher, 2012-02-28 22:27:32]

ptal at the gyp files. I've added it so:

- chromos implies ash
- use_ash implies use_aura
- (temporary) use_aura implies use_ash on windows and linux. (This will be
removed but is here to get the patch in and so we can get a linux_aura
trybot/buildbot running here.)

[Ben Goodger (Google), 2012-02-28 22:53:06]

If the trybots like it, so do I. LGTM.

[commit-bot: I haz the power, 2012-03-01 18:20:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/9478015/39002

[commit-bot: I haz the power, 2012-03-01 21:34:08]

Change committed as 124488

[sadrul, 2012-03-02 03:39:24]

http://codereview.chromium.org/9478015/diff/39002/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/9478015/diff/39002/build/common.gypi#newcode75
build/common.gypi:75: ['chromeos==1', {
Should this have been 'chromeos==1 and chromeos_gtk==0'?

[Elliot Glaysher, 2012-03-02 17:32:39]

http://codereview.chromium.org/9478015/diff/39002/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/9478015/diff/39002/build/common.gypi#newcode75
build/common.gypi:75: ['chromeos==1', {
On 2012/03/02 03:39:24, sadrul wrote:
> Should this have been 'chromeos==1 and chromeos_gtk==0'?

According to saintlou, that's redundant.

[Peter Mayo, 2012-03-04 16:17:56]

http://codereview.chromium.org/9478015/diff/39002/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/9478015/diff/39002/build/common.gypi#newcode75
build/common.gypi:75: ['chromeos==1', {
On 2012/03/02 17:32:39, Elliot Glaysher wrote:
> On 2012/03/02 03:39:24, sadrul wrote:
> > Should this have been 'chromeos==1 and chromeos_gtk==0'?
> 
> According to saintlou, that's redundant.

We need that to support merges for R18 & earlier.  He has forgotten this before.
 Please put this back unless there is some great shift in recent history.

[sadrul, 2012-03-04 16:18:59]

On 2012/03/04 16:17:56, Peter Mayo wrote:
> http://codereview.chromium.org/9478015/diff/39002/build/common.gypi
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/9478015/diff/39002/build/common.gypi#newcode75
> build/common.gypi:75: ['chromeos==1', {
> On 2012/03/02 17:32:39, Elliot Glaysher wrote:
> > On 2012/03/02 03:39:24, sadrul wrote:
> > > Should this have been 'chromeos==1 and chromeos_gtk==0'?
> > 
> > According to saintlou, that's redundant.
> 
> We need that to support merges for R18 & earlier.  He has forgotten this
before.
>  Please put this back unless there is some great shift in recent history.

I have a CL: http://codereview.chromium.org/9570065/ (there's also a thread)