Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 9478014: Make CrOS file manager determine .tar.gz/.tar.bz2 file type properly. (Closed)

Created:
8 years, 10 months ago by Ben Chan
Modified:
8 years, 9 months ago
Reviewers:
rginda, tbarzic
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Make CrOS file manager determine .tar.gz/.tar.bz2 file type properly. This CL modifies the FileType.getType function in the CrOS file manager extension to use RegExp patterns to check for the type of a given file URI, such that it determines .tar.bz and .tar.bz2 properly. BUG=chromium-os:26952 TEST=Tested the following: 1. Verify that CrOS file manager correctly shows all the file types listed in FileType.types. 2. Use the built-in JavaScript profiler to profile FileType.getType with 1000 .html files (the last entry in FileType.types), and make sure that there is no noticable slowdown in FileType.getType. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -59 lines) Patch
M chrome/browser/resources/file_manager/js/file_type.js View 2 chunks +68 lines, -59 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ben Chan
8 years, 10 months ago (2012-02-27 23:18:00 UTC) #1
tbarzic
On 2012/02/27 23:18:00, Ben Chan wrote: lgtm
8 years, 9 months ago (2012-02-28 17:35:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/9478014/1
8 years, 9 months ago (2012-02-28 17:59:02 UTC) #3
commit-bot: I haz the power
Presubmit check for 9478014-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-02-28 17:59:04 UTC) #4
rginda
lgtm
8 years, 9 months ago (2012-02-28 18:03:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/9478014/1
8 years, 9 months ago (2012-02-28 18:08:14 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-02-28 21:36:05 UTC) #7
Change committed as 124027

Powered by Google App Engine
This is Rietveld 408576698