Fix linking when in a WebKit only checkout.

Fix linking when in a WebKit only checkout.

third_party is in a different location relative to the output directory
in WebKit only checkouts.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123892

[tony, 2012-02-27 21:13:06]

This didn't show up on the bots because the bots have gold installed at
/usr/bin/ld.  Ryosuke hit this when trying to bring up a new bot.

[Evan Martin, 2012-02-27 21:24:53]

tears.  this is gonna be eneded some of the other product_dir hacks people have
since added.

LGTM

[Nico, 2012-02-27 21:27:38]

https://chromiumcodereview.appspot.com/9476013/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/9476013/diff/1/build/common.gypi#newco...
build/common.gypi:2031: 'gold_path':
'<(PRODUCT_DIR)/../../Source/WebKit/chromium/third_party/gold',
I thought webkit/chromium standalone isn't really buildable on linux, and anyone
working on webkit/chromium does so in a full chromium checkout. Is that not
true? (Does the ninja build for a standalone webkit work at all on linux?)

[rniwa-cr, 2012-02-27 21:35:25]

On 2012/02/27 21:27:38, Nico wrote:
https://chromiumcodereview.appspot.com/9476013/diff/1/build/common.gypi#newco...
> build/common.gypi:2031: 'gold_path':
> '<(PRODUCT_DIR)/../../Source/WebKit/chromium/third_party/gold',
> I thought webkit/chromium standalone isn't really buildable on linux, and
anyone
> working on webkit/chromium does so in a full chromium checkout. Is that not
> true? (Does the ninja build for a standalone webkit work at all on linux?)

chromium-linux bots on build.webkit.org certainly use this configuration.

[tony, 2012-02-27 21:50:44]

On 2012/02/27 21:27:38, Nico wrote:
> https://chromiumcodereview.appspot.com/9476013/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
>
https://chromiumcodereview.appspot.com/9476013/diff/1/build/common.gypi#newco...
> build/common.gypi:2031: 'gold_path':
> '<(PRODUCT_DIR)/../../Source/WebKit/chromium/third_party/gold',
> I thought webkit/chromium standalone isn't really buildable on linux, and
anyone
> working on webkit/chromium does so in a full chromium checkout. Is that not
> true?

In practice, I think most developers use a full chromium checkout because it's
less work than having a separate WebKit checkout.  The bots on build.webkit.org
definitely use this configuration so it's something we support.

> (Does the ninja build for a standalone webkit work at all on linux?)

I don't know.  There's no bot for it so it's not supported.  If we ever decide
that the ninja build is the default config for chromium, then I'll convert these
to ninja and get ninja working.

[tony, 2012-02-27 21:52:05]

What are some of the other product_dir hacks people have added?  This change
builds fine for me on my Linux desktop.

[Evan Martin, 2012-02-27 21:53:39]

http://code.google.com/codesearch#search/&exact_package=chromium&q=product_di...

On Mon, Feb 27, 2012 at 1:52 PM,  <tony@chromium.org> wrote:
> What are some of the other product_dir hacks people have added?  This change
> builds fine for me on my Linux desktop.
>
> https://chromiumcodereview.appspot.com/9476013/

[commit-bot: I haz the power, 2012-02-27 23:31:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/9476013/1

[commit-bot: I haz the power, 2012-02-28 05:17:28]

Change committed as 123892