Issue 9474034: Make base::Logging compile with the NaCl toolchain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9474034: Make base::Logging compile with the NaCl toolchain. (Closed)

Created:
8 years, 10 months ago by bbudge

Modified:
8 years, 9 months ago

Reviewers:
brettw

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make base::Logging compile with the NaCl toolchain. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124025

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -4 lines)			Patch
M	base/debug/debugger_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/debug/trace_event_impl.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/logging.cc	View		3 chunks	+7 lines, -3 lines	0 comments	Download
A	base/rand_util_nacl.cc	View	1	1 chunk	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bbudge

This gets some logging stuff working in the sandbox, and adds random number utilities.

8 years, 10 months ago (2012-02-28 01:34:22 UTC) #1

brettw

lgtm http://codereview.chromium.org/9474034/diff/1/base/debug/trace_event_impl.cc File base/debug/trace_event_impl.cc (right): http://codereview.chromium.org/9474034/diff/1/base/debug/trace_event_impl.cc#newcode338 base/debug/trace_event_impl.cc:338: #if !defined(OS_NACL) // NaCl shouldn't expose the process ...

8 years, 10 months ago (2012-02-28 04:43:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9474034/1

8 years, 9 months ago (2012-02-28 17:59:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9474034/12006

8 years, 9 months ago (2012-02-28 18:02:13 UTC) #4

Change committed as 124025

Expand Messages | Collapse Messages

Issue 9474034: Make base::Logging compile with the NaCl toolchain. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages