Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 9474023: Sync trace time on Chrome OS (just like Android) (Closed)

Created:
8 years, 10 months ago by Sam Leffler
Modified:
8 years, 9 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/git/chromium/src@master
Visibility:
Public.

Description

Sync trace time on Chrome OS (just like Android) Change-Id: I518e0c91a5f48ae1f5909d1e86a8fabfb97d1ec4 BUG=none TEST=record chrome events using about:tracing simultaneous with kernel events; check the resulting kernel event log for a trace_event_clock_sync record Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124144

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixup comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M base/debug/trace_event_impl.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nduca
LGTM with tweaked comments. @jar for official review. https://chromiumcodereview.appspot.com/9474023/diff/1/base/debug/trace_event_impl.cc File base/debug/trace_event_impl.cc (left): https://chromiumcodereview.appspot.com/9474023/diff/1/base/debug/trace_event_impl.cc#oldcode687 base/debug/trace_event_impl.cc:687: // ...
8 years, 10 months ago (2012-02-27 22:47:35 UTC) #1
jar (doing other things)
LGTM with nduca's suggestion. https://chromiumcodereview.appspot.com/9474023/diff/1/base/debug/trace_event_impl.cc File base/debug/trace_event_impl.cc (left): https://chromiumcodereview.appspot.com/9474023/diff/1/base/debug/trace_event_impl.cc#oldcode687 base/debug/trace_event_impl.cc:687: // Since Android does not ...
8 years, 10 months ago (2012-02-27 22:54:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sleffler@chromium.org/9474023/3001
8 years, 9 months ago (2012-02-28 21:31:10 UTC) #3
commit-bot: I haz the power
Try job failure for 9474023-3001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-02-28 22:46:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sleffler@chromium.org/9474023/3001
8 years, 9 months ago (2012-02-28 23:09:12 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-02-29 07:12:04 UTC) #6
Change committed as 124144

Powered by Google App Engine
This is Rietveld 408576698