chrome/browser/character_encoding.cc - Issue 9474020: [Coverity] CID 6203: pass std::string by const-ref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/character_encoding.cc

Issue 9474020: [Coverity] CID 6203: pass std::string by const-ref (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/character_encoding.cc

diff --git a/chrome/browser/character_encoding.cc b/chrome/browser/character_encoding.cc

index 460da9ef127e54e451200dab684eed06857217f7..4a6e3c5fbb408ef323fcbfd159f300e5f26baa9d 100644

--- a/chrome/browser/character_encoding.cc

+++ b/chrome/browser/character_encoding.cc

@@ -254,7 +254,7 @@ void ParseEncodingListSeparatedWithComma(

}

-string16 GetEncodingDisplayName(std::string encoding_name,

+string16 GetEncodingDisplayName(const std::string& encoding_name,

int category_string_id) {

string16 category_name = l10n_util::GetStringUTF16(category_string_id);

if (category_string_id != IDS_ENCODING_KOREAN &&

« no previous file with comments | « no previous file | no next file » | no next file with comments »