Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9474020: [Coverity] CID 6203: pass std::string by const-ref (Closed)

Created:
8 years, 9 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

[Coverity] CID 6203: pass std::string by const-ref BUG=none TEST=compile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123886

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/character_encoding.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Tyler Breisacher (Chromium)
8 years, 9 months ago (2012-02-27 21:39:35 UTC) #1
Dan Beam
lgtm
8 years, 9 months ago (2012-02-27 21:41:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9474020/1
8 years, 9 months ago (2012-02-27 23:30:30 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-02-28 03:50:53 UTC) #4 
Change committed as 123886

Powered by Google App Engine
This is Rietveld 408576698