Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: tests/gclient_scm_test.py

Issue 9474003: Remove flaky git tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_scm_test.py
diff --git a/tests/gclient_scm_test.py b/tests/gclient_scm_test.py
index d5818b2d9078244005389e0bb2a8be2d38e55b2e..94ab4203ac318613eaff080f6eb7beb7a97b4498 100755
--- a/tests/gclient_scm_test.py
+++ b/tests/gclient_scm_test.py
@@ -916,48 +916,6 @@ class ManagedGitWrapperTestCase(BaseGitWrapperTestCase):
'069c602044c5388d2d15c3f875b057c852003458\' in \'%s\'\nM\ta\nM\tb\n') %
join(self.root_dir, '.'))
- def testUpdateCheckout(self):
- if not self.enabled:
- return
- options = self.Options(verbose=True)
- root_dir = gclient_scm.os.path.realpath(tempfile.mkdtemp())
- relpath = 'foo'
- base_path = join(root_dir, relpath)
- url = join(self.base_path, '.git')
- try:
- scm = gclient_scm.CreateSCM(url=url, root_dir=root_dir,
- relpath=relpath)
- file_list = []
- scm.update(options, (), file_list)
- self.assertEquals(len(file_list), 2)
- self.assert_(gclient_scm.os.path.isfile(join(base_path, 'a')))
- self.assertEquals(scm.revinfo(options, (), None),
- '069c602044c5388d2d15c3f875b057c852003458')
- finally:
- rmtree(root_dir)
- msg1 = (
- "\n_____ foo at refs/heads/master\n\n"
- "________ running 'git clone --progress -b master --verbose %s %s' "
- "in '%s'\n"
- "Initialized empty Git repository in %s\n") % (
- join(self.root_dir, '.', '.git'),
- join(root_dir, 'foo'),
- root_dir,
- join(gclient_scm.os.path.realpath(root_dir), 'foo', '.git') + '/')
- msg2 = (
- "\n_____ foo at refs/heads/master\n\n"
- "________ running 'git clone --progress -b master --verbose %s %s'"
- " in '%s'\n"
- "Cloning into '%s'...\ndone.\n") % (
- join(self.root_dir, '.', '.git'),
- join(root_dir, 'foo'),
- root_dir,
- join(gclient_scm.os.path.realpath(root_dir), 'foo'))
- out = sys.stdout.getvalue()
- sys.stdout.close()
- sys.stdout = self._old_stdout
- self.assertTrue(out in (msg1, msg2), (out, msg1, msg2))
-
def testUpdateUpdate(self):
if not self.enabled:
return
@@ -1230,49 +1188,6 @@ class ManagedGitWrapperTestCaseMox(BaseTestCase):
class UnmanagedGitWrapperTestCase(BaseGitWrapperTestCase):
- def testUpdateCheckout(self):
- if not self.enabled:
- return
- options = self.Options(verbose=True)
- root_dir = gclient_scm.os.path.realpath(tempfile.mkdtemp())
- relpath = 'foo'
- base_path = join(root_dir, relpath)
- url = join(self.base_path, '.git')
- try:
- scm = gclient_scm.CreateSCM(url=url, root_dir=root_dir,
- relpath=relpath)
- file_list = []
- options.revision = 'unmanaged'
- scm.update(options, (), file_list)
- self.assertEquals(len(file_list), 2)
- self.assert_(gclient_scm.os.path.isfile(join(base_path, 'a')))
- self.assertEquals(scm.revinfo(options, (), None),
- '069c602044c5388d2d15c3f875b057c852003458')
- finally:
- rmtree(root_dir)
- msg1 = (
- "\n_____ foo at refs/heads/master\n\n"
- "________ running 'git clone --progress -b master --verbose %s %s'"
- " in '%s'\n"
- "Initialized empty Git repository in %s\n") % (
- join(self.root_dir, '.', '.git'),
- join(root_dir, 'foo'),
- root_dir,
- join(gclient_scm.os.path.realpath(root_dir), 'foo', '.git') + '/')
- msg2 = (
- "\n_____ foo at refs/heads/master\n\n"
- "________ running 'git clone --progress -b master --verbose %s %s'"
- " in '%s'\n"
- "Cloning into '%s'...\ndone.\n") % (
- join(self.root_dir, '.', '.git'),
- join(root_dir, 'foo'),
- root_dir,
- join(gclient_scm.os.path.realpath(root_dir), 'foo'))
- out = sys.stdout.getvalue()
- sys.stdout.close()
- sys.stdout = self._old_stdout
- self.assertTrue(out in (msg1, msg2), (out, msg1, msg2))
-
def testUpdateUpdate(self):
if not self.enabled:
return
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698