chrome/browser/tab_contents/thumbnail_generator.cc - Issue 9473001: Extract minimal RenderViewHost interface for embedders, leaving

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/thumbnail_generator.cc

Issue 9473001: Extract minimal RenderViewHost interface for embedders, leaving (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ready for initial review. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/thumbnail_generator.cc

diff --git a/chrome/browser/tab_contents/thumbnail_generator.cc b/chrome/browser/tab_contents/thumbnail_generator.cc

index 1ff460f6b6c6aa80265502b7735640cb498aa8a7..0dd1f3a02a144030c9b18fafb54fe1cb2084446c 100644

--- a/chrome/browser/tab_contents/thumbnail_generator.cc

+++ b/chrome/browser/tab_contents/thumbnail_generator.cc

@@ -482,7 +482,7 @@ void ThumbnailGenerator::UpdateThumbnail(

// Compute the thumbnail score.

ThumbnailScore score;

score.at_top =

- (web_contents->GetRenderViewHost()->last_scroll_offset().y() == 0);

+ (web_contents->GetRenderViewHost()->GetLastScrollOffset().y() == 0);

score.boring_score = ThumbnailGenerator::CalculateBoringScore(&thumbnail);

score.good_clipping =

(clip_result == ThumbnailGenerator::kTallerThanWide ||