chrome/browser/favicon/favicon_tab_helper.cc - Issue 9473001: Extract minimal RenderViewHost interface for embedders, leaving

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 9473001: Extract minimal RenderViewHost interface for embedders, leaving (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ready for initial review. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_tab_helper.cc

diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc

index 8afdea97fff3da45121d997ba74e63c5c36cfbc1..c77ff3ebc2c6a43d1aebf39232d56d6f805504e8 100644

--- a/chrome/browser/favicon/favicon_tab_helper.cc

+++ b/chrome/browser/favicon/favicon_tab_helper.cc

@@ -142,7 +142,7 @@ NavigationEntry* FaviconTabHelper::GetActiveEntry() {

void FaviconTabHelper::StartDownload(int id, const GURL& url, int image_size) {

RenderViewHost* host = web_contents()->GetRenderViewHost();

host->Send(new IconMsg_DownloadFavicon(

- host->routing_id(), id, url, image_size));

+ host->GetRoutingID(), id, url, image_size));

}

void FaviconTabHelper::NotifyFaviconUpdated() {