chrome/browser/extensions/execute_code_in_tab_function.cc - Issue 9473001: Extract minimal RenderViewHost interface for embedders, leaving

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/execute_code_in_tab_function.cc

Issue 9473001: Extract minimal RenderViewHost interface for embedders, leaving (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ready for initial review. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/execute_code_in_tab_function.cc

diff --git a/chrome/browser/extensions/execute_code_in_tab_function.cc b/chrome/browser/extensions/execute_code_in_tab_function.cc

index 35e7b3cd8bd4e11f3ace072f2e1bb022a5b92b4c..b052ace45002c7f346c85fbf48320f4d8caf4323 100644

--- a/chrome/browser/extensions/execute_code_in_tab_function.cc

+++ b/chrome/browser/extensions/execute_code_in_tab_function.cc

@@ -226,7 +226,8 @@ bool ExecuteCodeInTabFunction::Execute(const std::string& code_string) {

params.in_main_world = false;

contents->web_contents()->GetRenderViewHost()->Send(

new ExtensionMsg_ExecuteCode(

- contents->web_contents()->GetRenderViewHost()->routing_id(), params));

+ contents->web_contents()->GetRenderViewHost()->GetRoutingID(),

+ params));

Observe(contents->web_contents());

AddRef(); // balanced in OnExecuteCodeFinished()