Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 9473001: Extract minimal RenderViewHost interface for embedders, leaving (Closed)

Created:
8 years, 10 months ago by Jói
Modified:
8 years, 9 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, yoshiki+watch_chromium.org, dcheng, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, aboxhall+watch_chromium.org, achuith+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, dtseng+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, davidbarr+watch_chromium.org, rdsmith+dwatch_chromium.org, James Su
Visibility:
Public.

Description

Extract minimal RenderViewHost interface for embedders, leaving RenderViewHostImpl for content. TBR=darin@chromium.org BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124941

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : Ready for initial review. #

Total comments: 8

Patch Set 4 : Merge to LKGR, address a couple of review nits. #

Patch Set 5 : Merge to LKGR, fix a weird runtime issue. #

Total comments: 4

Patch Set 6 : Address Darin's review comments. #

Patch Set 7 : Merge to LKGR (pure merge). #

Patch Set 8 : Version for commit. #

Patch Set 9 : Merge to LKGR (pure merge). #

Patch Set 10 : Merge to LKGR. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1764 lines, -1390 lines) Patch
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_external_delegate.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 7 8 11 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_util.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/notifications/balloon_view.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_extension_api.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 2 3 4 5 6 7 8 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_debugger_api.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_handler.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_page_capture_api.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tab_id_map.cc View 1 2 3 4 5 6 7 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/file_select_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 2 5 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 2 3 4 5 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/oom_priority_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager_delegate_impl.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_installer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 3 4 5 6 7 8 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/printing/background_printing_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm View 1 2 3 4 5 5 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/offline_resource_throttle.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/transfer_navigation_resource_throttle.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 2 3 4 5 6 7 8 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_tab_observer.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/restore_tab_helper.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/chrome_web_contents_view_gtk_delegate.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_view_gtk.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt_win.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_views.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_utils_x11.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_utils2_x11.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/signin/login_ui_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/task_manager_handler.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_test_handler.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_event_listener.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_ppb_pdf_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension_handler.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension_handler.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/page_capture_custom_bindings.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/schema_generated_bindings.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/tabs_custom_bindings.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_idle_scheduler.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/external_extension.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/safe_browsing/malware_dom_details.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/translate_helper.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/accessibility/renderer_accessibility_browsertest.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/debugger/devtools_frontend_host.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/debugger/devtools_manager_impl.cc View 1 2 chunks +10 lines, -7 lines 0 comments Download
M content/browser/debugger/render_view_devtools_agent_host.cc View 1 2 4 chunks +9 lines, -7 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_request_handle.cc View 1 2 3 4 5 6 7 2 chunks +7 lines, -6 lines 0 comments Download
M content/browser/download/mhtml_generation_manager.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/download/save_file_manager.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/download/save_package.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/geolocation_dispatcher_host.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/host_zoom_map_impl.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/intents/intent_injector.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/backing_store_manager.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/cross_site_resource_handler.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/gtk_im_context_wrapper.cc View 1 2 3 4 5 7 chunks +18 lines, -13 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper_message_filter.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 2 3 4 5 6 7 8 12 chunks +317 lines, -196 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 2 3 4 5 6 7 8 50 chunks +311 lines, -276 lines 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.h View 1 2 3 4 5 6 7 8 16 chunks +203 lines, -144 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.cc View 1 2 3 4 5 6 7 8 24 chunks +83 lines, -56 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 3 4 5 6 7 8 12 chunks +24 lines, -19 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 6 7 8 13 chunks +29 lines, -30 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.mm View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 5 6 7 8 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 1 2 3 4 5 6 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 2 3 4 5 6 7 8 3 chunks +15 lines, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 2 3 4 5 6 7 8 5 chunks +14 lines, -7 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac.mm View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac_unittest.mm View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/speech/speech_input_manager_impl.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/ssl/ssl_error_handler.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/tab_contents/interstitial_page_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/interstitial_page_impl.cc View 1 2 3 4 5 12 chunks +21 lines, -18 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/tab_contents/popup_menu_helper_mac.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/popup_menu_helper_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.h View 1 2 3 6 chunks +8 lines, -11 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 1 2 3 20 chunks +54 lines, -41 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 1 2 3 22 chunks +43 lines, -38 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 3 4 5 6 7 8 28 chunks +59 lines, -41 lines 0 comments Download
M content/browser/tab_contents/tab_contents_unittest.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_helper.cc View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_win.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/test_tab_contents.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/tab_contents/web_contents_view_mac.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/web_drag_dest_gtk.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/tab_contents/web_drag_dest_gtk.cc View 5 chunks +15 lines, -12 lines 0 comments Download
M content/browser/tab_contents/web_drag_source_gtk.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -1 line 0 comments Download
M content/browser/tab_contents/web_drag_source_gtk.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M content/browser/tab_contents/web_drag_source_mac.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/webui/web_ui_impl.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/browser/render_view_host_observer.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -4 lines 0 comments Download
M content/public/browser/render_view_host_observer.cc View 1 2 3 4 5 6 7 3 chunks +7 lines, -3 lines 0 comments Download
M content/public/browser/web_contents_observer.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -3 lines 0 comments Download
M content/public/renderer/render_view.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/mouse_lock_dispatcher_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M content/shell/layout_test_controller_bindings.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/shell.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M content/shell/shell_render_view_host_observer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Jói
Hi guys, I'm signing off for the night and this is more or less ready ...
8 years, 9 months ago (2012-02-28 23:13:26 UTC) #1
jam
lgtm after Darin oks the AsImpl. I'd really prefer we don't have it (RenderViewHostDelegate::GetAsWebContents() still ...
8 years, 9 months ago (2012-02-29 01:40:47 UTC) #2
Jói
Darin: I just need your stamp of approval for the RenderWidgetHost::AsRWHImpl() method. Alternatively, a suggestion ...
8 years, 9 months ago (2012-02-29 16:07:35 UTC) #3
darin (slow to review)
http://codereview.chromium.org/9473001/diff/29001/content/browser/renderer_host/render_view_host.h File content/browser/renderer_host/render_view_host.h (right): http://codereview.chromium.org/9473001/diff/29001/content/browser/renderer_host/render_view_host.h#newcode301 content/browser/renderer_host/render_view_host.h:301: #if defined(OS_WIN) nit: maybe this should be #if defined(COMPILER_MSVC) ...
8 years, 9 months ago (2012-03-01 23:15:39 UTC) #4
Jói
Darin, I took your feedback as "OK to commit with a better schema than AsRWHImpl()" ...
8 years, 9 months ago (2012-03-02 10:40:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/9473001/40205
8 years, 9 months ago (2012-03-02 13:59:28 UTC) #6
commit-bot: I haz the power
Try job failure for 9473001-40205 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-02 15:25:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/9473001/40205
8 years, 9 months ago (2012-03-02 15:41:22 UTC) #8
commit-bot: I haz the power
Can't apply patch for file content/browser/renderer_host/render_view_host.cc. While running patch -p1 --forward --force; patching file content/browser/renderer_host/render_view_host.cc ...
8 years, 9 months ago (2012-03-02 17:18:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/9473001/44001
8 years, 9 months ago (2012-03-04 11:34:20 UTC) #10
commit-bot: I haz the power
Try job failure for 9473001-44001 (retry) on mac_rel for step "net_unittests". It's a second try, ...
8 years, 9 months ago (2012-03-04 13:37:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/9473001/47002
8 years, 9 months ago (2012-03-05 13:36:44 UTC) #12
commit-bot: I haz the power
8 years, 9 months ago (2012-03-05 15:16:03 UTC) #13
Change committed as 124941

Powered by Google App Engine
This is Rietveld 408576698