Expand the instruction visitor to visit computations and values.

runtime/vm/flow_graph_builder.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_BUILDER_H_
 #define VM_FLOW_GRAPH_BUILDER_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
@@ skipping 125 matching lines @@
   Value* value() const { return value_; }
 
  private:
   // Helper to set the output state to return a Value.
   void ReturnValue(Value* value) { value_ = value; }
 
   // Helper to append a Bind instruction to the graph and return its
   // temporary value (i.e., set the output parameters).
   void ReturnValueOf(Computation* computation) {
     AddInstruction(new BindInstr(temp_index(), computation));
-    value_ = new TempValue(AllocateTempIndex());
+    value_ = new TempVal(AllocateTempIndex());

[Kevin Millikin (Google), 2012/02/27 11:52:27]

I'm not in love with the abbreviated name, but it is at least consistent with
XxxComp and XxxInstr.

   }
 
   // Output parameters.
   Value* value_;
 };
 
 
 // Translate an AstNode to a control-flow graph fragment for both its
 // effects and true/false control flow (e.g., for an expression in a test
 // context).  The resulting graph is always closed (even if it is empty)
@@ skipping 41 matching lines @@
   }
 
  private:
   // Construct and concatenate a Branch instruction to this graph fragment.
   // Closes the fragment and sets the output parameters.
   void BranchOnValue(Value* value);
 
   // Helper to bind a computation and branch on its value.
   void BranchOnValueOf(Computation* computation) {
     AddInstruction(new BindInstr(temp_index(), computation));
-    BranchOnValue(new TempValue(temp_index()));
+    BranchOnValue(new TempVal(temp_index()));
   }
 
   // Output parameters.
   TargetEntryInstr** true_successor_address_;
   TargetEntryInstr** false_successor_address_;
 };
 
 #undef DEFINE_VISIT
 
 
 }  // namespace dart
 
 #endif  // VM_FLOW_GRAPH_BUILDER_H_