Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 9471: Adds import/export of bookmarks to bookmarks.html file.... (Closed)

Created:
12 years, 1 month ago by sky
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adds import/export of bookmarks to bookmarks.html file. BUG=1649 TEST=bring up bookmark manager and try out import/export from the tools menu. Note that import ALWAYS creates a new folder under the 'Other bookmarks folder' with the name of Imported (x). This is by design. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4968

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1065 lines, -152 lines) Patch
M base/task.h View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.h View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 1 chunk +12 lines, -15 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/bookmarks/bookmark_html_writer.h View 1 chunk +27 lines, -0 lines 0 comments Download
A chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +332 lines, -0 lines 0 comments Download
A chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 1 chunk +125 lines, -0 lines 0 comments Download
M chrome/browser/browser.scons View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/importer/firefox2_importer.h View 2 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/importer/firefox2_importer.cc View 6 chunks +63 lines, -31 lines 0 comments Download
M chrome/browser/importer/firefox3_importer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/importer/ie_importer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/importer/importer.h View 8 chunks +48 lines, -8 lines 0 comments Download
M chrome/browser/importer/importer.cc View 6 chunks +91 lines, -43 lines 0 comments Download
M chrome/browser/importer/importer_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/importer/toolbar_importer.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/shell_dialogs.h View 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_manager_view.h View 6 chunks +26 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_manager_view.cc View 1 2 8 chunks +168 lines, -4 lines 0 comments Download
M chrome/browser/views/importing_progress_view.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/views/importing_progress_view.cc View 6 chunks +29 lines, -6 lines 0 comments Download
M chrome/browser/views/shell_dialogs.cc View 9 chunks +23 lines, -14 lines 0 comments Download
M chrome/test/unit/unit_tests.scons View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/views/tree_view.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/views/tree_view.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M net/base/escape.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
12 years, 1 month ago (2008-11-06 22:04:55 UTC) #1
jcampan
I think you are missing the base/escape.cc file. http://codereview.chromium.org/9471/diff/1/5 File chrome/browser/views/bookmark_manager_view.cc (right): http://codereview.chromium.org/9471/diff/1/5#newcode440 Line 440: ...
12 years, 1 month ago (2008-11-07 00:33:50 UTC) #2
jcampan
12 years, 1 month ago (2008-11-07 00:40:07 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698