DescriptionPassword support for NativeTextfieldViews, in the model
This is an alternate implementation of issue 8747001 (see discussion there).
Advantages:
* It works in Windows.
* It's arguably a simpler design: the abstraction boundary between the obscured and real text is the same as the abstraction boundary between RenderText and TextfieldViewsModel.
Problems:
* The cursoring code should not be in RenderText, and moving it into the model where it belongs would break the aforementioned abstraction. In other words, I think this design is simpler by accident (the fact that the other version doesn't work on Windows is also an accident). In the long term I think I would rather maintain the other version, though it's possible I'm overlooking something.
* It's an ugly change in practice because a lot of calls to RenderText have to be wrapped. The RenderText version touches less code if you ignore the gratuitous identifier renaming. I could try introducing a RenderTextWrapper class instead of patching each call site, but I'm not sure it would help.
There are no unit tests yet, which means this code is probably broken. But the basic functionality is there.
BUG=105054
TEST=
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|