Add prefs UI tests for Incognito exceptions for new Settings UI.

Add prefs UI tests for Incognito exceptions for new Settings UI.

TEST=none
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124962

[Nirnimesh, 2012-02-24 23:49:47]

LGTM

http://codereview.chromium.org/9467013/diff/4/chrome/test/functional/prefs_ui.py
File chrome/test/functional/prefs_ui.py (right):

http://codereview.chromium.org/9467013/diff/4/chrome/test/functional/prefs_ui...
chrome/test/functional/prefs_ui.py:75: msg=('No displayed host name matches
pattern "%s"' % hostname_pattern))
remove inner params

[kkania, 2012-02-27 00:56:35]

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/prefs...
File chrome/test/functional/prefs_ui.py (right):

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/prefs...
chrome/test/functional/prefs_ui.py:142: self._VerifyIncognitoContentExceptionUI(
how about do all this without loading the page thrice?

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/webdr...
File chrome/test/functional/webdriver_pages/settings.py (right):

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/webdr...
chrome/test/functional/webdriver_pages/settings.py:333:
'.//*[@id="content-settings-exceptions-area"]'
i don't think this should be that complicated

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/webdr...
chrome/test/functional/webdriver_pages/settings.py:354: if not incognito:
is there a reason why you just don't detect whether the incognito list is
present or not? Or, how about just pass the list_elem?

[dyu1, 2012-02-27 20:54:45]

Questions for kkania

http://codereview.chromium.org/9467013/diff/4/chrome/test/functional/prefs_ui.py
File chrome/test/functional/prefs_ui.py (right):

http://codereview.chromium.org/9467013/diff/4/chrome/test/functional/prefs_ui...
chrome/test/functional/prefs_ui.py:75: msg=('No displayed host name matches
pattern "%s"' % hostname_pattern))
On 2012/02/24 23:49:47, Nirnimesh wrote:
> remove inner params

Done.

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/prefs...
File chrome/test/functional/prefs_ui.py (right):

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/prefs...
chrome/test/functional/prefs_ui.py:142: self._VerifyIncognitoContentExceptionUI(
On 2012/02/27 00:56:35, kkania wrote:
> how about do all this without loading the page thrice?

I'm not sure what you mean since this test is similar to
testExceptionsEntryCorrectlyDisplayed. The only difference is using
self._VerifyContentExceptionUI vs self.VerifyIncognitoContentExceptionsUI. The
previous test was given a LGTM, so what has changed?

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/webdr...
File chrome/test/functional/webdriver_pages/settings.py (right):

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/webdr...
chrome/test/functional/webdriver_pages/settings.py:333:
'.//*[@id="content-settings-exceptions-area"]'
On 2012/02/27 00:56:35, kkania wrote:
> i don't think this should be that complicated

Line 326 is similar. The only difference is with @mode for incognito. Why would
this be considered complicated but the previous xpath is not?

[kkania, 2012-02-28 00:51:30]

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/prefs...
File chrome/test/functional/prefs_ui.py (right):

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/prefs...
chrome/test/functional/prefs_ui.py:142: self._VerifyIncognitoContentExceptionUI(
I didn't think about it. How about something like this:

geo_exception = (
    {'http://maps.google.com:80/': {'http://maps.google.com': 2},
     'http://gmail.com:80/': {'h.....'},
     '...': '...'})
self.SetPrefs(pyauto.kGeolocationContentSettings, geo_exception)
page = settings.ManageExceptionsPage.FromNavigation(self._driver,
ContentTypes.GEOLOCATION)
exceptions = page.GetExceptions(incognito=True)
expected_exceptions = {
  'http://maps.google.com:80/': Behaviors.BLOCK,
  'http://gmail.com:80/': Behaviors.ASK,
  'http://yahoo.com:80': Behaviors.DENY]
for host, behavior in expected_exceptions.iteritems():
  self.assertTrue(exceptions.has_key(host),
                  msg='No displayed host name matches pattern "%s"' % host)
  self.assertEqual(expected_exceptions[host], exceptions[host])

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/webdr...
File chrome/test/functional/webdriver_pages/settings.py (right):

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/webdr...
chrome/test/functional/webdriver_pages/settings.py:338:
self._incognito_list_elem = None
try this:

if incognito_list_elem.is_displayed():
  self._list_elem = incognito_list_elem
  self._is_incognito = True
else:
  self._is_incognito = False

[dyu1, 2012-02-29 22:50:15]

removed some tests and added some new tests. I've kept the original incognito
pattern where the tests will pass in whether to test for the normal mode list or
incognito list. With the new settings suggestions I wasn't able to distinguish
the tests since both list elements are shown on the same settings page.

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/webdr...
File chrome/test/functional/webdriver_pages/settings.py (right):

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/webdr...
chrome/test/functional/webdriver_pages/settings.py:338:
self._incognito_list_elem = None
I tried it this way but I wasn't able to write my tests specific to the
incognito sections in exceptions settings. Your suggestion implies that the
incognito section exists. Since Settings page is independent of either browser
modes I can't specify what section to test on. 

On 2012/02/28 00:51:30, kkania wrote:
> try this:
> 
> if incognito_list_elem.is_displayed():
>   self._list_elem = incognito_list_elem
>   self._is_incognito = True
> else:
>   self._is_incognito = False

http://codereview.chromium.org/9467013/diff/5001/chrome/test/functional/webdr...
chrome/test/functional/webdriver_pages/settings.py:354: if not incognito:
Well the incognito list isn't present on all exception settings page. Also if it
is present I want to be able to have specific tests for the regular list and the
incognito list on the same exceptions page.

On 2012/02/27 00:56:35, kkania wrote:
> is there a reason why you just don't detect whether the incognito list is
> present or not? Or, how about just pass the list_elem?

[kkania, 2012-03-02 16:44:23]

Talked offline. Let me know when you've made changes again.

[dyu1, 2012-03-02 19:34:26]

Added additional tests and added a windex option for GetPrefs function in
pyauto.py.

[kkania, 2012-03-03 02:02:27]

lgtm

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/pref...
File chrome/test/functional/prefs_ui.py (right):

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/pref...
chrome/test/functional/prefs_ui.py:184: self._driver, ContentTypes.PLUGINS)
bad indentation and several places below

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/pref...
chrome/test/functional/prefs_ui.py:195:
page.AddNewException(**plugins_exception)
this is pretty fancy, but can you just do it the normal way

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/pref...
chrome/test/functional/prefs_ui.py:200: def
testCorrectBehaviorSetInIncognitoUI(self):
remove?

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/webd...
File chrome/test/functional/webdriver_pages/settings.py (right):

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/webd...
chrome/test/functional/webdriver_pages/settings.py:332:
self._incognito_list_elem = driver.find_element_by_xpath(
Consider the alternative design we talked about. Up to you.

[dyu1, 2012-03-03 02:16:45]

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/pref...
File chrome/test/functional/prefs_ui.py (right):

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/pref...
chrome/test/functional/prefs_ui.py:184: self._driver, ContentTypes.PLUGINS)
On 2012/03/03 02:02:27, kkania wrote:
> bad indentation and several places below

Done.

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/pref...
chrome/test/functional/prefs_ui.py:195:
page.AddNewException(**plugins_exception)
On 2012/03/03 02:02:27, kkania wrote:
> this is pretty fancy, but can you just do it the normal way

Done.

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/pref...
chrome/test/functional/prefs_ui.py:200: def
testCorrectBehaviorSetInIncognitoUI(self):
Removing since SetPrefs() function doesn't offer the capability of setting
behavior or patterns within Incognito mode. This test just happens to work based
on the behavior, thus removing until capability is added. 

On 2012/03/03 02:02:27, kkania wrote:
> remove?

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/webd...
File chrome/test/functional/webdriver_pages/settings.py (right):

http://codereview.chromium.org/9467013/diff/21001/chrome/test/functional/webd...
chrome/test/functional/webdriver_pages/settings.py:332:
self._incognito_list_elem = driver.find_element_by_xpath(
Will refactor the class at a later time.

On 2012/03/03 02:02:27, kkania wrote:
> Consider the alternative design we talked about. Up to you.