Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: compiler/javatests/com/google/dart/corelib/SharedTests.java

Issue 9466041: Removes dependency on v8 from dartc testing (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/corelib/SharedTests.java
diff --git a/compiler/javatests/com/google/dart/corelib/SharedTests.java b/compiler/javatests/com/google/dart/corelib/SharedTests.java
index 3dc32203c827eee90ccd926cf06a9998028c0986..c32337ab2b288ab3bd0c70b81c28b907970f76b1 100644
--- a/compiler/javatests/com/google/dart/corelib/SharedTests.java
+++ b/compiler/javatests/com/google/dart/corelib/SharedTests.java
@@ -6,7 +6,6 @@ package com.google.dart.corelib;
import com.google.common.io.CharStreams;
import com.google.common.io.LineReader;
-import com.google.dart.runner.V8Launcher;
import junit.extensions.TestSetup;
import junit.framework.Test;
@@ -50,12 +49,6 @@ public class SharedTests extends TestSetup {
protected static class SuiteBuilder {
protected TestSuite buildSuite() {
TestSuite suite = new TestSuite("Shared Dart tests");
-
- if (!V8Launcher.isConfigured()) {
- return configurationProblem(suite,
- "Please set the system property com.google.dart.runner.d8");
- }
-
File file = new File(listTests[0]);
if (!file.canExecute()) {
return configurationProblem(suite, file.getPath() + " is not executable");

Powered by Google App Engine
This is Rietveld 408576698