Issue 9466039: Disable StatsTableTest.MultipleThreads on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9466039: Disable StatsTableTest.MultipleThreads on Mac. (Closed)

Created:
8 years, 10 months ago by vandebo (ex-Chrome)

Modified:
8 years, 10 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable StatsTableTest.MultipleThreads on Mac. It's failing on the Mac Valgrind bot TBR=thestig@chromium.org BUG=10611 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123672

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	base/metrics/stats_table_unittest.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/9466039/1

8 years, 10 months ago (2012-02-25 21:08:03 UTC) #2

Lei Zhang

Is it only failing on Valgrind? If so, you can disable it via tools/valgrind/gtest_exclude/... instead ...

8 years, 10 months ago (2012-02-26 23:42:39 UTC) #4

vandebo (ex-Chrome)

8 years, 10 months ago (2012-02-27 17:36:43 UTC) #5

On 2012/02/26 23:42:39, Lei Zhang wrote:
> Is it only failing on Valgrind? If so, you can disable it via
> tools/valgrind/gtest_exclude/... instead of disabling the test all together.

If it's flaking on mac valgrind, then there's still a race on mac (unless
valgrind is removing the effect of the locking primitives).

Expand Messages | Collapse Messages