Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 9465014: Added yoshiki@chromium.org to task-manager related OWNERS files. (Closed)

Created:
8 years, 10 months ago by Kevin Greer
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Added yoshiki@chromium.org to task-manager related OWNERS files, as estade requested. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124973

Patch Set 1 #

Patch Set 2 : Added two new OWNERS files. #

Patch Set 3 : Added new OWNERS file. #

Total comments: 1

Patch Set 4 : Moved task_manager webui code to own sub-directory. #

Patch Set 5 : merge with trunk #

Patch Set 6 : Fix for mac make file. #

Patch Set 7 : Fixed task_manager include. #

Patch Set 8 : Fixed include path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -849 lines) Patch
A chrome/browser/resources/task_manager/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/task_manager/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/webui/task_manager/OWNERS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/ui/webui/task_manager/task_manager_dialog.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/task_manager/task_manager_dialog.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/task_manager/task_manager_handler.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/task_manager/task_manager_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/task_manager/task_manager_ui.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/task_manager/task_manager_ui.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/webui/task_manager_dialog.h View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/webui/task_manager_dialog.cc View 1 2 3 1 chunk +0 lines, -205 lines 0 comments Download
D chrome/browser/ui/webui/task_manager_handler.h View 1 2 3 4 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/ui/webui/task_manager_handler.cc View 1 2 3 4 1 chunk +0 lines, -406 lines 0 comments Download
D chrome/browser/ui/webui/task_manager_ui.h View 1 2 3 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/webui/task_manager_ui.cc View 1 2 3 1 chunk +0 lines, -95 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Kevin Greer
Please accept so that we don't need your review for task-manager related CL's.
8 years, 10 months ago (2012-02-24 17:41:30 UTC) #1
Evan Stade
http://codereview.chromium.org/9465014/diff/1002/chrome/browser/ui/webui/OWNERS File chrome/browser/ui/webui/OWNERS (right): http://codereview.chromium.org/9465014/diff/1002/chrome/browser/ui/webui/OWNERS#newcode5 chrome/browser/ui/webui/OWNERS:5: yoshiki@chromium.org # for task_manager_* please create a subdir for ...
8 years, 10 months ago (2012-02-24 20:46:18 UTC) #2
Kevin Greer
I've moved the task-manager webui files to their own sub-directory and only added yoshiki to ...
8 years, 9 months ago (2012-02-28 17:15:21 UTC) #3
Evan Stade
thank you. LGTM.
8 years, 9 months ago (2012-02-28 19:53:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9465014/7001
8 years, 9 months ago (2012-02-29 14:45:59 UTC) #5
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/webui/task_manager/task_manager_handler.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/webui/task_manager/task_manager_handler.cc ...
8 years, 9 months ago (2012-02-29 14:46:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9465014/13001
8 years, 9 months ago (2012-02-29 21:51:43 UTC) #7
commit-bot: I haz the power
Try job failure for 9465014-13001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-02-29 22:43:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9465014/19001
8 years, 9 months ago (2012-03-01 12:50:43 UTC) #9
commit-bot: I haz the power
Presubmit check for 9465014-19001 failed and returned exit status 1. /mnt/data/b/commit-queue/workdir/chromium/third_party/closure_linter/closure_linter/javascriptlintrules.py:28: DeprecationWarning: the sets module ...
8 years, 9 months ago (2012-03-01 12:50:52 UTC) #10
Kevin Greer
Hi Rohitrao and Sail, I've moved the task_manager code to its own subdirectory, and I ...
8 years, 9 months ago (2012-03-01 14:14:37 UTC) #11
sail
lgtm
8 years, 9 months ago (2012-03-01 18:16:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9465014/19001
8 years, 9 months ago (2012-03-01 18:25:43 UTC) #13
commit-bot: I haz the power
Try job failure for 9465014-19001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-01 19:19:22 UTC) #14
Kevin Greer
I've moved task_manager code to its own subdirectory and need someone with OWNER-ship of chrome/browser/ui/views/frame/browser_view.cc ...
8 years, 9 months ago (2012-03-01 21:06:21 UTC) #15
sky
LGTM Feel free to TBR changes like this in the future.
8 years, 9 months ago (2012-03-01 22:02:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9465014/28001
8 years, 9 months ago (2012-03-01 22:04:12 UTC) #17
commit-bot: I haz the power
Try job failure for 9465014-28001 (retry) on win_rel for step "net_unittests". It's a second try, ...
8 years, 9 months ago (2012-03-02 00:04:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9465014/28001
8 years, 9 months ago (2012-03-02 15:24:12 UTC) #19
commit-bot: I haz the power
Try job failure for 9465014-28001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-02 16:15:19 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9465014/28001
8 years, 9 months ago (2012-03-02 19:38:00 UTC) #21
commit-bot: I haz the power
Try job failure for 9465014-28001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-02 21:11:45 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9465014/36003
8 years, 9 months ago (2012-03-02 21:52:24 UTC) #23
commit-bot: I haz the power
Try job failure for 9465014-36003 (previous was lost) (retry) on mac_rel for steps "browser_tests, ui_tests" ...
8 years, 9 months ago (2012-03-03 00:47:39 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9465014/36003
8 years, 9 months ago (2012-03-05 14:42:54 UTC) #25
commit-bot: I haz the power
Try job failure for 9465014-36003 (retry) on mac_rel for step "net_unittests". It's a second try, ...
8 years, 9 months ago (2012-03-05 16:58:34 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9465014/36003
8 years, 9 months ago (2012-03-05 17:05:16 UTC) #27
commit-bot: I haz the power
8 years, 9 months ago (2012-03-05 18:41:30 UTC) #28
Change committed as 124973

Powered by Google App Engine
This is Rietveld 408576698