Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: runtime/bin/extensions.cc

Issue 9465004: Add native extensions for the Dart shell to mac and windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/extensions.h"
6
5 #include <stdio.h> 7 #include <stdio.h>
6 #include <dlfcn.h>
7 8
8 #include "include/dart_api.h" 9 #include "include/dart_api.h"
9 #include "platform/assert.h" 10 #include "platform/assert.h"
10 #include "platform/globals.h" 11 #include "platform/globals.h"
11 #include "bin/extensions.h"
12 #include "bin/dartutils.h" 12 #include "bin/dartutils.h"
13 13
14 Dart_Handle Extensions::LoadExtension(const char* extension_url, 14 Dart_Handle Extensions::LoadExtension(const char* extension_url,
15 Dart_Handle parent_library) { 15 Dart_Handle parent_library) {
16 // TODO(whesse): Consider making loading extensions lazy, so the
17 // dynamic library is loaded only when first native function is called.
18 ASSERT(DartUtils::IsDartExtensionSchemeURL(extension_url)); 16 ASSERT(DartUtils::IsDartExtensionSchemeURL(extension_url));
19 const char* library_name = 17 const char* library_name =
20 extension_url + strlen(DartUtils::kDartExtensionScheme); 18 extension_url + strlen(DartUtils::kDartExtensionScheme);
21 if (strchr(library_name, '/') != NULL) { 19 if (strchr(library_name, '/') != NULL ||
20 strchr(library_name, '\\') != NULL) {
22 return Dart_Error("path components not allowed in extension library name"); 21 return Dart_Error("path components not allowed in extension library name");
23 } 22 }
24 const int buffer_length = strlen(library_name) + strlen("./lib.so") + 1; 23 void* library_handle = LoadExtensionLibrary(library_name);
25 char* library_path = new char[buffer_length]; 24 if (!library_handle) {
26 snprintf(library_path, buffer_length, "./lib%s.so", library_name);
27
28 void* lib_handle = dlopen(library_path, RTLD_LAZY);
29 if (!lib_handle) {
30 delete[] library_path;
31 return Dart_Error("cannot find extension library"); 25 return Dart_Error("cannot find extension library");
32 } 26 }
33 // Reuse library_path buffer for intialization function name. 27
34 char* library_init_function = library_path; 28 char* init_function_name = MakeString("%s_Init", library_name);
35 snprintf(library_init_function, buffer_length, "%s_Init", library_name);
36 typedef Dart_Handle (*InitFunctionType)(Dart_Handle import_map); 29 typedef Dart_Handle (*InitFunctionType)(Dart_Handle import_map);
37 InitFunctionType fn = reinterpret_cast<InitFunctionType>( 30 InitFunctionType fn = reinterpret_cast<InitFunctionType>(
38 dlsym(lib_handle, library_init_function)); 31 ResolveSymbol(library_handle, init_function_name));
39 delete[] library_path; 32 delete[] init_function_name;
40 char *error = dlerror(); 33
41 if (error != NULL) { 34 if (fn == NULL) {
42 return Dart_Error(error); 35 return Dart_Error("cannot find initialization function in extension");
43 } 36 }
44 return (*fn)(parent_library); 37 return (*fn)(parent_library);
45 } 38 }
39
40 // Returns a newly allocated string by printing name using format.
41 // The string must be deleted by the caller.
42 char* Extensions::MakeString(const char* format, const char* name) {
43 const int buffer_length = strlen(name) + strlen(format) + 1;
44 char* new_string = new char[buffer_length];
45 snprintf(new_string, buffer_length, format, name);
46 return new_string;
47 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698