Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Side by Side Diff: runtime/bin/extensions_macos.cc

Issue 9465004: Add native extensions for the Dart shell to mac and windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add MacOS implementation, refactor and create extensions.cc Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/extensions.h" 5 #include "bin/extensions.h"
6 #include <dlfcn.h>
6 7
7 #include "include/dart_api.h" 8 void* Extensions::LoadExtensionLibrary(const char* library_name) {
8 #include "platform/assert.h" 9 char* library_path = MakeString("./%s.so", library_name);
Mads Ager (google) 2012/03/07 14:31:48 lib%s.so? Either that or remove the lib prefix on
Ivan Posva 2012/03/07 19:06:23 Please do not use .so extensions on Mac OS X. It i
Bill Hesse 2012/03/08 12:04:37 libfoo.so on linux and foo.dll on windows is the n
Bill Hesse 2012/03/08 12:04:37 This is not a .dylib. This is a bundle, not a sha
10 void* lib_handle = dlopen(library_path, RTLD_LAZY);
11 delete[] library_path;
12 return lib_handle;
13 }
9 14
10 Dart_Handle Extensions::LoadExtension(const char* extension_url, 15 void* Extensions::ResolveSymbol(void* lib_handle, const char* symbol) {
11 Dart_Handle parent_library) { 16 void* result = dlsym(lib_handle, symbol);
12 UNIMPLEMENTED(); 17 if (dlerror() != NULL) return NULL;
13 return NULL; 18 return result;
14 } 19 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698