Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: src/stub-cache.cc

Issue 9464054: Do not call memset() to initialize StubCache. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/isolate.cc ('K') | « src/isolate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 25 matching lines...) Expand all
36 #include "stub-cache.h" 36 #include "stub-cache.h"
37 #include "vm-state-inl.h" 37 #include "vm-state-inl.h"
38 38
39 namespace v8 { 39 namespace v8 {
40 namespace internal { 40 namespace internal {
41 41
42 // ----------------------------------------------------------------------- 42 // -----------------------------------------------------------------------
43 // StubCache implementation. 43 // StubCache implementation.
44 44
45 45
46 StubCache::StubCache(Isolate* isolate) : isolate_(isolate) { 46 StubCache::StubCache(Isolate* isolate) : isolate_(isolate) {
Sven Panne 2012/02/27 13:03:29 Merge the constructor with the Initialize function
47 ASSERT(isolate == Isolate::Current()); 47 ASSERT(isolate == Isolate::Current());
48 memset(primary_, 0, sizeof(primary_[0]) * StubCache::kPrimaryTableSize);
49 memset(secondary_, 0, sizeof(secondary_[0]) * StubCache::kSecondaryTableSize);
50 } 48 }
51 49
52 50
53 void StubCache::Initialize(bool create_heap_objects) { 51 void StubCache::Initialize(bool create_heap_objects) {
54 ASSERT(IsPowerOf2(kPrimaryTableSize)); 52 ASSERT(IsPowerOf2(kPrimaryTableSize));
55 ASSERT(IsPowerOf2(kSecondaryTableSize)); 53 ASSERT(IsPowerOf2(kSecondaryTableSize));
56 if (create_heap_objects) { 54 if (create_heap_objects) {
57 HandleScope scope; 55 HandleScope scope;
58 Code* empty = isolate_->builtins()->builtin(Builtins::kIllegal); 56 Code* empty = isolate_->builtins()->builtin(Builtins::kIllegal);
59 for (int i = 0; i < kPrimaryTableSize; i++) { 57 for (int i = 0; i < kPrimaryTableSize; i++) {
(...skipping 1473 matching lines...) Expand 10 before | Expand all | Expand 10 after
1533 Handle<FunctionTemplateInfo>( 1531 Handle<FunctionTemplateInfo>(
1534 FunctionTemplateInfo::cast(signature->receiver())); 1532 FunctionTemplateInfo::cast(signature->receiver()));
1535 } 1533 }
1536 } 1534 }
1537 1535
1538 is_simple_api_call_ = true; 1536 is_simple_api_call_ = true;
1539 } 1537 }
1540 1538
1541 1539
1542 } } // namespace v8::internal 1540 } } // namespace v8::internal
OLDNEW
« src/isolate.cc ('K') | « src/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698