Do not call memset() to initialize StubCache.

src/isolate.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1612 matching lines @@
 
   delete descriptor_lookup_cache_;
   descriptor_lookup_cache_ = NULL;
   delete context_slot_cache_;
   context_slot_cache_ = NULL;
   delete keyed_lookup_cache_;
   keyed_lookup_cache_ = NULL;
 
   delete transcendental_cache_;
   transcendental_cache_ = NULL;
-  delete stub_cache_;
+  free(stub_cache_);

[Sven Panne, 2012/02/27 13:03:29]

Leave this as-is.

   stub_cache_ = NULL;
   delete stats_table_;
   stats_table_ = NULL;
 
   delete logger_;
   logger_ = NULL;
 
   delete counters_;
   counters_ = NULL;
 
@@ skipping 128 matching lines @@
   transcendental_cache_ = new TranscendentalCache();
   keyed_lookup_cache_ = new KeyedLookupCache();
   context_slot_cache_ = new ContextSlotCache();
   descriptor_lookup_cache_ = new DescriptorLookupCache();
   unicode_cache_ = new UnicodeCache();
   inner_pointer_to_code_cache_ = new InnerPointerToCodeCache(this);
   write_input_buffer_ = new StringInputBuffer();
   global_handles_ = new GlobalHandles(this);
   bootstrapper_ = new Bootstrapper();
   handle_scope_implementer_ = new HandleScopeImplementer(this);
-  stub_cache_ = new StubCache(this);
+  stub_cache_ = new (calloc(1, sizeof(StubCache))) StubCache(this);

[Sven Panne, 2012/02/27 13:03:29]

I think we can remove this line completely and replace it with something
below...

[ulan, 2012/02/27 16:13:02]

Unfortunately, builtins.SetUp() assumes that stub_cache->isolate_ is
initialized.

   regexp_stack_ = new RegExpStack();
   regexp_stack_->isolate_ = this;
 
   // Enable logging before setting up the heap
   logger_->SetUp();
 
   CpuProfiler::SetUp();
   HeapProfiler::SetUp();
 
   // Initialize other runtime facilities
@@ skipping 36 matching lines @@
   }
 
   if (FLAG_preemption) {
     v8::Locker locker;
     v8::Locker::StartPreemption(100);
   }
 
 #ifdef ENABLE_DEBUGGER_SUPPORT
   debug_->SetUp(create_heap_objects);
 #endif
   stub_cache_->Initialize(create_heap_objects);

[Sven Panne, 2012/02/27 13:03:29]

Remove this line.

[ulan, 2012/02/27 16:13:02]

Done.

 
   // If we are deserializing, read the state into the now-empty heap.
   if (des != NULL) {
     des->Deserialize();
     stub_cache_->Initialize(true);

[Sven Panne, 2012/02/27 13:03:29]

I think we can move this Initialize past the condition and replace it with a
"stub_cache_ = new StubCache(this);" there, because I doubt that the
uninitialized StubCache can be used before this point, anyway.

[ulan, 2012/02/27 16:13:02]

Moved Initialize().

   }
 
   // Finish initialization of ThreadLocal after deserialization is done.
   clear_pending_exception();
   clear_pending_message();
   clear_scheduled_exception();
 
   // Deserializing may put strange things in the root array's copy of the
   // stack guard.
   heap_.SetStackLimits();
@@ skipping 97 matching lines @@
 
 #ifdef DEBUG
 #define ISOLATE_FIELD_OFFSET(type, name, ignored)                       \
 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_);
 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET)
 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET)
 #undef ISOLATE_FIELD_OFFSET
 #endif
 
 } }  // namespace v8::internal