Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: chrome/browser/resources/options2/browser_options.html

Issue 9464053: Hide/Disable several (meaningless) options in Settings uber-page for Guest. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Declarative way Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/browser_options.html
diff --git a/chrome/browser/resources/options2/browser_options.html b/chrome/browser/resources/options2/browser_options.html
index 0f358f5e680455fbaafbef10fdc1943bd39e2e62..fdafec1fb19d4018770fcfadfad5f024a50c85ad 100644
--- a/chrome/browser/resources/options2/browser_options.html
+++ b/chrome/browser/resources/options2/browser_options.html
@@ -104,7 +104,7 @@
<button id="themes-reset" i18n-content="themesReset"></button>
</div>
</if>
- <div class="settings-row">
+ <div class="settings-row" guest-visibility="disabled">
<span i18n-content="homePage"></span>
<select id="home-page-select">
<option value="none" i18n-content="homePageNone"></option>
@@ -113,7 +113,7 @@
<option value="choose" i18n-content="homePageChoose"></option>
</select>
</div>
- <div class="checkbox"><label>
+ <div class="checkbox" guest-visibility="disabled"><label>
<input type="checkbox" pref="bookmark_bar.show_on_all_tabs"
metric="Options_ShowBookmarksBar">
<span i18n-content="toolbarShowBookmarksBar"></span>
@@ -160,7 +160,7 @@
i18n-content="defaultSearchManageEngines">
</button>
</div>
- <div class="checkbox">
+ <div class="checkbox" guest-visibility="disabled">
<label id="instant-label">
<!-- TODO(estade): metric? -->
<input id="instant-field-trial-control" type="checkbox"
@@ -174,7 +174,7 @@
</div>
</div>
</section>
- <section>
+ <section guest-visibility="hidden">
<h3 i18n-content="sectionTitleUsers"></h3>
<if expr="pp_ifdef('chromeos')">
<div id="sync-section">
@@ -256,10 +256,14 @@
<section>
<h3 i18n-content="datetimeTitle"></h3>
<div class="option-control-table">
- <span class="option-name" i18n-content="timezone"></span>
- <div id="timezone-value">
- <select id="timezone-select" class="control" i18n-options="timezoneList"
- data-type="string" pref="cros.system.timezone"></select>
+ <div guest-visibility="disabled">
+ <span class="option-name" i18n-content="timezone"></span>
+ <div id="timezone-value">
+ <select id="timezone-select" class="control"
+ i18n-options="timezoneList" data-type="string"
+ pref="cros.system.timezone">
+ </select>
+ </div>
</div>
<div class="checkbox">
<label>
@@ -298,14 +302,14 @@
<span i18n-content="linkDoctorPref"></span>
</label>
</div>
- <div class="checkbox">
+ <div class="checkbox" guest-visibility="disabled">
<label>
<input id="searchSuggestEnabled" pref="search.suggest_enabled"
metric="Options_UseSuggestCheckbox" type="checkbox">
<span i18n-content="suggestPref"></span>
</label>
</div>
- <div class="checkbox">
+ <div class="checkbox" guest-visibility="disabled">
<label>
<input id="dnsPrefetchingEnabled" pref="dns_prefetching.enabled"
metric="Options_DnsPrefetchCheckbox" type="checkbox">
@@ -546,7 +550,7 @@
<if expr="pp_ifdef('chromeos')">
<!-- This section is duplicated here for ChromeOS. This must stay in sync
with the section above. -->
- <section id="startup-section">
+ <section id="startup-section" guest-visibility="hidden">
<h3 i18n-content="sectionTitleStartup"></h3>
<div>
<div class="radio">

Powered by Google App Engine
This is Rietveld 408576698