Hide/Disable several (meaningless) options in Settings uber-page for Guest.

chrome/browser/resources/options2/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 99 matching lines @@
             pref,
             self.onHomePagePrefChanged_.bind(self));
       });
 
       $('themes-gallery').onclick = function(event) {
         window.open(localStrings.getString('themesGalleryURL'));
       };
       $('themes-reset').onclick = function(event) {
         chrome.send('themesReset');
       };
+      if (cr.isChromeOS) {
+        // Appearance section.
+        if (AccountsOptions.loggedInAsGuest()) {

[James Hawkins, 2012/03/05 17:07:12]

Combine this if with if (cr.isChromeOS).

[Denis Kuznetsov (DE-MUC), 2012/03/12 10:32:15]

Done.

+          AccountsOptions.disableElementsForGuest(
+              $('home-page-select-container'));
+          AccountsOptions.disableElementsForGuest(
+              $('bookmarkbar-show-on-all-tabs-group'));
+          // Search section
+          AccountsOptions.disableElementsForGuest($('instant-setting'));
+        }
+      }
 
       // Device section (ChromeOS only).
       if (cr.isChromeOS) {
         $('keyboard-settings-button').onclick = function(evt) {
           OptionsPage.navigateToPage('keyboard-overlay');
         };
         $('pointer-settings-button').onclick = function(evt) {
           OptionsPage.navigateToPage('pointer-overlay');
         };
         this.initBrightnessButton_('brightness-decrease-button',
@@ skipping 64 matching lines @@
         if (selectedProfile)
           ManageProfileOverlay.showManageDialog(selectedProfile);
       };
       $('profiles-delete').onclick = function(event) {
         var selectedProfile = self.getSelectedProfileItem_();
         if (selectedProfile)
           ManageProfileOverlay.showDeleteDialog(selectedProfile);
       };
 
       if (cr.isChromeOS) {
+        if (AccountsOptions.loggedInAsGuest()) {
+          // Disable the screen lock checkbox in guest mode.
+          AccountsOptions.disableElementsForGuest($('enable-screen-lock'));
+
+          // Hide the startup and users sections in Guest mode.
+          $('startup-section').hidden = true;
+          $('users-section').hidden = true;
+        } else {
+          $('account-picture-wrapper').onclick = function(event) {
+            OptionsPage.navigateToPage('changePicture');
+          };
+        }
+
         // Username (canonical email) of the currently logged in user or
         // |kGuestUser| if a guest session is active.
         this.username_ = localStrings.getString('username');
 
         this.updateAccountPicture_();
 
-        if (cr.commandLine && cr.commandLine.options['--bwsi']) {
-          // Disable the screen lock checkbox in guest mode.
-          $('enable-screen-lock').disabled = true;
-
-          // Hide the startup section in Guest mode.
-          $('startup-section').hidden = true;
-        } else {
-          $('account-picture-wrapper').onclick = function(event) {
-            OptionsPage.navigateToPage('changePicture');
-          };
-        }
-
         $('manage-accounts-button').onclick = function(event) {
           OptionsPage.navigateToPage('accounts');
           chrome.send('coreOptionsUserMetricsAction',
               ['Options_ManageAccounts']);
         };
       } else {
         $('import-data').onclick = function(event) {
           // Make sure that any previous import success message is hidden, and
           // we're showing the UI to import further data.
           $('import-data-configure').hidden = false;
@@ skipping 14 matching lines @@
         $('set-as-default-browser').onclick = function(event) {
           chrome.send('becomeDefaultBrowser');
         };
 
         $('auto-launch').onclick = this.handleAutoLaunchChanged_;
       }
 
       // Date and time section (CrOS only).
       if (cr.isChromeOS && AccountsOptions.loggedInAsGuest()) {
         // Disable time-related settings if we're not logged in as a real user.
-        $('timezone-select').disabled = true;
-        $('use-24hour-clock').disabled = true;
+        AccountsOptions.disableElementsForGuest($('timezone-value-group'));
+        AccountsOptions.disableElementsForGuest($('use-24hour-clock'));
       }
 
       // Privacy section.
       $('privacyContentSettingsButton').onclick = function(event) {
         OptionsPage.navigateToPage('content');
         OptionsPage.showTab($('cookies-nav-tab'));
         chrome.send('coreOptionsUserMetricsAction',
             ['Options_ContentSettings']);
       };
       $('privacyClearDataButton').onclick = function(event) {
         OptionsPage.navigateToPage('clearBrowserData');
         chrome.send('coreOptionsUserMetricsAction', ['Options_ClearData']);
       };
       // 'metricsReportingEnabled' element is only present on Chrome branded
       // builds.
       if ($('metricsReportingEnabled')) {
         $('metricsReportingEnabled').onclick = function(event) {
           chrome.send('metricsReportingCheckboxAction',
               [String(event.target.checked)]);
         };
       }
 
+      if (cr.isChromeOS && AccountsOptions.loggedInAsGuest()) {
+        AccountsOptions.disableElementsForGuest(
+            $('search-suggest-enabled-group'));
+        AccountsOptions.disableElementsForGuest(
+            $('dns-prefetching-enabled-group'));
+      }
+
+
       // Bluetooth (CrOS only).
       if (cr.isChromeOS) {
         options.system.bluetooth.BluetoothDeviceList.decorate(
             $('bluetooth-paired-devices-list'));
 
         $('bluetooth-add-device').onclick =
             this.handleAddBluetoothDevice_.bind(this);
 
         $('enable-bluetooth').onchange = function(event) {
           var state = $('enable-bluetooth').checked;
@@ skipping 26 matching lines @@
         OptionsPage.navigateToPage('autofill');
         chrome.send('coreOptionsUserMetricsAction',
             ['Options_ShowAutofillSettings']);
       };
       $('manage-passwords').onclick = function(event) {
         OptionsPage.navigateToPage('passwords');
         OptionsPage.showTab($('passwords-nav-tab'));
         chrome.send('coreOptionsUserMetricsAction',
             ['Options_ShowPasswordManager']);
       };
-      if (this.guestModeActive_()) {
+      if (cr.isChromeOS && AccountsOptions.loggedInAsGuest()) {
         // Disable and turn off Autofill in guest mode.
         var autofillEnabled = $('autofill-enabled');
         autofillEnabled.disabled = true;
         autofillEnabled.checked = false;
         cr.dispatchSimpleEvent(autofillEnabled, 'change');
         $('autofill-settings').disabled = true;
 
         // Disable and turn off Password Manager in guest mode.
         var passwordManagerEnabled = $('password-manager-enabled');
         passwordManagerEnabled.disabled = true;
         passwordManagerEnabled.checked = false;
         cr.dispatchSimpleEvent(passwordManagerEnabled, 'change');
         $('manage-passwords').disabled = true;
 
         // Hide the entire section on ChromeOS
-        if (cr.isChromeOS)
-          $('passwords-and-autofill-section').hidden = true;
+        AccountsOptions.disableElementsForGuest(
+            $('passwords-and-autofill-section'));
       }
       $('mac-passwords-warning').hidden =
           !(localStrings.getString('macPasswordsWarning'));
 
       // Network section.
       if (!cr.isChromeOS) {
         $('proxiesConfigureButton').onclick = function(event) {
           chrome.send('showNetworkProxySettings');
         };
       }
@@ skipping 591 matching lines @@
      * @private
      */
     setMetricsReportingSettingVisibility_: function(visible) {
       if (visible)
         $('metricsReportingSetting').style.display = 'block';
       else
         $('metricsReportingSetting').style.display = 'none';
     },
 
     /**
-     * Returns whether the browser in guest mode. Some features are disabled or
-     * hidden in guest mode.
-     * @return {boolean} True if guest mode is currently active.
-     * @private
-     */
-    guestModeActive_: function() {
-      return cr.commandLine && cr.commandLine.options['--bwsi'];
-    },
-
-    /**
      * Set the font size selected item.
      * @private
      */
     setFontSize_: function(font_size_value) {
       var selectCtl = $('defaultFontSize');
       for (var i = 0; i < selectCtl.options.length; i++) {
         if (selectCtl.options[i].value == font_size_value) {
           selectCtl.selectedIndex = i;
           if ($('Custom'))
             selectCtl.remove($('Custom').index);
@@ skipping 205 matching lines @@
       // the Bluetooth pairing overlay.
       if (device.pairing)
         BluetoothPairing.showDialog(device);
     },
   };
 
   //Forward public APIs to private implementations.
   [
     'addBluetoothDevice',
     'getStartStopSyncButton',
-    'guestModeActive',
     'hideBluetoothSettings',
     'removeCloudPrintConnectorSection',
     'setAutoOpenFileTypesDisabledAttribute',
     'setBackgroundModeCheckboxState',
     'setBluetoothState',
     'setCheckRevocationCheckboxState',
     'setFontSize',
     'setGtkThemeButtonEnabled',
     'setHighContrastCheckboxState',
     'setInstantFieldTrialStatus',
@@ skipping 33 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });