Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 9464024: Adding the android specific platorm_util file. (Closed)

Created:
8 years, 10 months ago by Ramya
Modified:
8 years, 9 months ago
Reviewers:
Yaron, jam
CC:
chromium-reviews
Visibility:
Public.

Description

Adding the android specific platorm_util file. BUG=115682 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123880

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding this file to chrome_browser.gypi #

Patch Set 3 : Updated copyright and removed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
A chrome/browser/platform_util_android.cc View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ramya
8 years, 10 months ago (2012-02-24 19:59:21 UTC) #1
Yaron
lgtm http://codereview.chromium.org/9464024/diff/1/chrome/browser/platform_util_android.cc File chrome/browser/platform_util_android.cc (right): http://codereview.chromium.org/9464024/diff/1/chrome/browser/platform_util_android.cc#newcode1 chrome/browser/platform_util_android.cc:1: // Copyright (c) 2010 The Chromium Authors. All ...
8 years, 10 months ago (2012-02-24 20:34:22 UTC) #2
jam
lgtm, but please remove all the comments from the .cc file. no need duplicating them ...
8 years, 10 months ago (2012-02-24 21:28:52 UTC) #3
Ramya
http://codereview.chromium.org/9464024/diff/1/chrome/browser/platform_util_android.cc File chrome/browser/platform_util_android.cc (right): http://codereview.chromium.org/9464024/diff/1/chrome/browser/platform_util_android.cc#newcode1 chrome/browser/platform_util_android.cc:1: // Copyright (c) 2010 The Chromium Authors. All rights ...
8 years, 10 months ago (2012-02-24 21:59:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/9464024/4002
8 years, 10 months ago (2012-02-27 23:29:46 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-02-28 03:42:45 UTC) #6
Change committed as 123880

Powered by Google App Engine
This is Rietveld 408576698