chrome/browser/ui/panels/panel.cc - Issue 9463022: Minimized panels should not open on Windows when activated by the OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 9463022: Minimized panels should not open on Windows when activated by the OS (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/panels/overflow_panel_strip.cc ('k') | chrome/browser/ui/panels/panel_browser_view.h » ('j') | chrome/browser/ui/panels/panel_browser_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel.cc

diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc

index 8e08f364448f60eccb174968c11a378eb89bc606..fe405d396a267dca198ef3504cb958e0a2f146c3 100644

--- a/chrome/browser/ui/panels/panel.cc

+++ b/chrome/browser/ui/panels/panel.cc

@@ -157,6 +157,9 @@ void Panel::MoveToStrip(PanelStrip* new_strip) {

panel_strip_ = new_strip;

panel_strip_->AddPanel(this);

+ native_panel_->PreventActivationByOS(panel_strip_->TreatAllPanelsAsMinimized()

+ || expansion_state_ != EXPANDED);

content::NotificationService::current()->Notify(

chrome::NOTIFICATION_PANEL_CHANGED_LAYOUT_MODE,

content::Source<Panel>(this),

@@ -175,6 +178,9 @@ void Panel::SetExpansionState(ExpansionState new_state) {

if (expansion_state_ == MINIMIZED)

Deactivate();

+ native_panel_->PreventActivationByOS(panel_strip_->TreatAllPanelsAsMinimized()

+ || expansion_state_ != EXPANDED);

content::NotificationService::current()->Notify(

chrome::NOTIFICATION_PANEL_CHANGED_EXPANSION_STATE,

content::Source<Panel>(this),