Minimized panels should not open on Windows when activated by the OS

chrome/browser/ui/panels/panel_browser_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_view.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "chrome/browser/native_window_notification_source.h"
 #include "chrome/browser/ui/panels/panel.h"
@@ skipping 285 matching lines @@
 }
 
 void PanelBrowserView::DeactivatePanel() {
   Deactivate();
 }
 
 bool PanelBrowserView::IsPanelActive() const {
   return IsActive();
 }
 
+void PanelBrowserView::PreventActivationByOS(bool prevent_activation) {
+  // set the flags "NoActivate" and "AppWindow" to make sure

[jennb, 2012/03/01 23:21:28]

s/set/Set

+  // the minimized panels do not get activated by the OS, but
+  // do appear in the taskbar and Alt-Tab menu.
+  gfx::NativeWindow native_window = GetNativePanelHandle();
+  int style = ::GetWindowLong(native_window, GWL_EXSTYLE);
+
+  if (prevent_activation)
+      ::SetWindowLong(native_window, GWL_EXSTYLE,

[jennb, 2012/03/01 23:21:28]

Should be indented 2 spaces instead of 4. Continuation lines indent by 4.

+          style |  WS_EX_NOACTIVATE | WS_EX_APPWINDOW);
+  else // allow activation
+      ::SetWindowLong(native_window, GWL_EXSTYLE,
+          style & ~WS_EX_NOACTIVATE & ~WS_EX_APPWINDOW);
+
+}
+
+
 gfx::NativeWindow PanelBrowserView::GetNativePanelHandle() {
   return GetNativeHandle();
 }
 
 void PanelBrowserView::UpdatePanelTitleBar() {
   UpdateTitleBar();
 }
 
 void PanelBrowserView::UpdatePanelLoadingAnimations(bool should_animate) {
   UpdateLoadingAnimations(should_animate);
@@ skipping 309 matching lines @@
 }
 
 bool NativePanelTestingWin::IsWindowSizeKnown() const {
   return true;
 }
 
 bool NativePanelTestingWin::IsAnimatingBounds() const {
   return panel_browser_view_->bounds_animator_.get() &&
          panel_browser_view_->bounds_animator_->is_animating();
 }