Minimized panels should not open on Windows when activated by the OS

chrome/browser/ui/panels/panel.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel.h"
 
 #include "base/logging.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 45 matching lines @@
 
 Panel::~Panel() {
   // Invoked by native panel destructor. Do not access native_panel_ here.
 }
 
 void Panel::Initialize(const gfx::Rect& bounds) {
   DCHECK(!initialized_);
   DCHECK(!bounds.IsEmpty());
   initialized_ = true;
   native_panel_ = CreateNativePanel(browser_, this, bounds);
+  if (panel_strip_ != NULL)
+    native_panel_->PreventActivationByOS(panel_strip_->IsPanelMinimized(this));
 }
 
 void Panel::OnNativePanelClosed() {
   if (auto_resizable_)
     native_panel_->GetPanelBrowser()->tabstrip_model()->RemoveObserver(this);
   manager()->OnPanelClosed(this);
   DCHECK(!panel_strip_);
 }
 
 PanelManager* Panel::manager() const {
@@ skipping 73 matching lines @@
   ConfigureAutoResize(browser()->GetSelectedWebContents());
 }
 
 void Panel::SetAppIconVisibility(bool visible) {
   if (app_icon_visible_ == visible)
     return;
   app_icon_visible_ = visible;
   native_panel_->SetPanelAppIconVisibility(visible);
 }
 
+void  Panel::set_panel_strip(PanelStrip* new_strip) {
+  panel_strip_ = new_strip;
+  if (panel_strip_ != NULL && initialized_)
+    native_panel_->PreventActivationByOS(panel_strip_->IsPanelMinimized(this));

[jennb, 2012/03/06 21:56:44]

This makes more sense in AddPanel where the panel strip is already setting
various properties on the panel? That will require Panel.h to add a
PreventActivationByOS() as strips never access native_panel directly.

+}
+
 void Panel::SetExpansionState(ExpansionState new_state) {
   if (expansion_state_ == new_state)
     return;
   old_expansion_state_ = expansion_state_;
   expansion_state_ = new_state;
 
   manager()->OnPanelExpansionStateChanged(this);
 
   // The minimized panel should not get the focus.
   if (expansion_state_ == MINIMIZED)
     Deactivate();
 
+  DCHECK(initialized_ && panel_strip_ != NULL);

[jennb, 2012/03/06 21:56:44]

Move this to the beginning of the method? Both these should be true when this
method is called.

+  native_panel_->PreventActivationByOS(panel_strip_->IsPanelMinimized(this));
+
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PANEL_CHANGED_EXPANSION_STATE,
       content::Source<Panel>(this),
       content::NotificationService::NoDetails());
 }
 
 bool Panel::IsDrawingAttention() const {
   return native_panel_->IsDrawingAttention();
 }
 
@@ skipping 496 matching lines @@
       native_panel_->ContentSizeFromWindowSize(max_size_));
 }
 
 void Panel::OnWindowSizeAvailable() {
   ConfigureAutoResize(browser()->GetSelectedWebContents());
 }
 
 void Panel::DestroyBrowser() {
   native_panel_->DestroyPanelBrowser();
 }