chrome/browser/webdata/autofill_profile_syncable_service.cc - Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/webdata/autofill_profile_syncable_service.cc

Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fred's review Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/webdata/autocomplete_syncable_service.cc ('k') | chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/webdata/autofill_profile_syncable_service.cc

diff --git a/chrome/browser/webdata/autofill_profile_syncable_service.cc b/chrome/browser/webdata/autofill_profile_syncable_service.cc

index 892cf88f117f9513d19ecfcb1380ef567fcbb211..f2da26ab09cd5452d0cdc7a725058b05ce406734 100644

--- a/chrome/browser/webdata/autofill_profile_syncable_service.cc

+++ b/chrome/browser/webdata/autofill_profile_syncable_service.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/autofill/form_group.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/sync/api/sync_error.h"

+#include "chrome/browser/sync/protocol/sync.pb.h"

#include "chrome/browser/webdata/autofill_table.h"

#include "chrome/browser/webdata/web_data_service.h"

#include "chrome/browser/webdata/web_database.h"

@@ -196,7 +197,7 @@ SyncError AutofillProfileSyncableService::ProcessSyncChanges(

break;

case SyncChange::ACTION_DELETE: {

std::string guid = i->sync_data().GetSpecifics().

- GetExtension(sync_pb::autofill_profile).guid();

+ autofill_profile().guid();

bundle.profiles_to_delete.push_back(guid);

profiles_map_.erase(guid);

} break;

@@ -300,7 +301,7 @@ void AutofillProfileSyncableService::WriteAutofillProfile(

const AutofillProfile& profile,

sync_pb::EntitySpecifics* profile_specifics) {

sync_pb::AutofillProfileSpecifics* specifics =

- profile_specifics->MutableExtension(sync_pb::autofill_profile);

+ profile_specifics->mutable_autofill_profile();

DCHECK(guid::IsValidGUID(profile.guid()));

@@ -363,7 +364,7 @@ AutofillProfileSyncableService::CreateOrUpdateProfile(

const sync_pb::EntitySpecifics& specifics = data.GetSpecifics();

const sync_pb::AutofillProfileSpecifics& autofill_specifics(

- specifics.GetExtension(sync_pb::autofill_profile));

+ specifics.autofill_profile());

GUIDToProfileMap::iterator it = profile_map->find(

autofill_specifics.guid());