Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chrome/browser/sync/test/engine/mock_connection_manager.cc

Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fred's review Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/engine/mock_connection_manager.cc
diff --git a/chrome/browser/sync/test/engine/mock_connection_manager.cc b/chrome/browser/sync/test/engine/mock_connection_manager.cc
index b32aa218583daa4889d991e4ed73a8cfde45e116..0b2e2e4714a414f011b6e10eabe8461bab2834b2 100644
--- a/chrome/browser/sync/test/engine/mock_connection_manager.cc
+++ b/chrome/browser/sync/test/engine/mock_connection_manager.cc
@@ -190,9 +190,9 @@ void MockConnectionManager::AddDefaultBookmarkData(sync_pb::SyncEntity* entity,
}
} else {
entity->set_folder(is_folder);
- entity->mutable_specifics()->MutableExtension(sync_pb::bookmark);
+ entity->mutable_specifics()->mutable_bookmark();
if (!is_folder) {
- entity->mutable_specifics()->MutableExtension(sync_pb::bookmark)->
+ entity->mutable_specifics()->mutable_bookmark()->
set_url("http://google.com");
}
}
@@ -617,7 +617,7 @@ bool MockConnectionManager::IsModelTypePresentInSpecifics(
const google::protobuf::RepeatedPtrField<
sync_pb::DataTypeProgressMarker>& filter,
syncable::ModelType value) {
- int data_type_id = syncable::GetExtensionFieldNumberFromModelType(value);
+ int data_type_id = syncable::GetSpecificsFieldNumberFromModelType(value);
for (int i = 0; i < filter.size(); ++i) {
if (filter.Get(i).data_type_id() == data_type_id) {
return true;
@@ -631,7 +631,7 @@ sync_pb::DataTypeProgressMarker const*
const google::protobuf::RepeatedPtrField<
sync_pb::DataTypeProgressMarker>& filter,
syncable::ModelType value) {
- int data_type_id = syncable::GetExtensionFieldNumberFromModelType(value);
+ int data_type_id = syncable::GetSpecificsFieldNumberFromModelType(value);
for (int i = 0; i < filter.size(); ++i) {
if (filter.Get(i).data_type_id() == data_type_id) {
return &(filter.Get(i));
« no previous file with comments | « chrome/browser/sync/syncable/syncable_unittest.cc ('k') | chrome/browser/sync/test/engine/proto_extension_validator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698