chrome/browser/sync/profile_sync_service_preference_unittest.cc - Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_preference_unittest.cc

Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fred's review Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_autofill_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_session_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_preference_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_preference_unittest.cc b/chrome/browser/sync/profile_sync_service_preference_unittest.cc

index e67b0c977428734b2e51432b478a0a20c2d52b5c..14ee6727355ef5f873e423b64ec0812f918f8669 100644

--- a/chrome/browser/sync/profile_sync_service_preference_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_preference_unittest.cc

@@ -176,7 +176,7 @@ class ProfileSyncServicePreferenceTest

return NULL;

const sync_pb::PreferenceSpecifics& specifics(

- node.GetEntitySpecifics().GetExtension(sync_pb::preference));

+ node.GetEntitySpecifics().preference());

JSONReader reader;

return reader.JsonToValue(specifics.value(), false, false);

@@ -267,7 +267,7 @@ TEST_F(ProfileSyncServicePreferenceTest, CreatePrefSyncData) {

*pref->GetValue(), &sync_data));

EXPECT_EQ(std::string(prefs::kHomePage), sync_data.GetTag());

const sync_pb::PreferenceSpecifics& specifics(sync_data.GetSpecifics().

- GetExtension(sync_pb::preference));

+ preference());

EXPECT_EQ(std::string(prefs::kHomePage), specifics.name());

base::JSONReader reader;