chrome/browser/sync/glue/password_change_processor.cc - Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/password_change_processor.cc

Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fred's review Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/engine/verify_updates_command_unittest.cc ('k') | chrome/browser/sync/glue/session_change_processor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/password_change_processor.cc

diff --git a/chrome/browser/sync/glue/password_change_processor.cc b/chrome/browser/sync/glue/password_change_processor.cc

index a2fb04e2ef82bec919168850c9ac40f2e75211b4..87efd19f70311676cab5e97b9179f1e2ffdebb12 100644

--- a/chrome/browser/sync/glue/password_change_processor.cc

+++ b/chrome/browser/sync/glue/password_change_processor.cc

@@ -175,7 +175,7 @@ void PasswordChangeProcessor::ApplyChangesFromSyncModel(

changes.Get().begin(); it != changes.Get().end(); ++it) {

if (sync_api::ChangeRecord::ACTION_DELETE ==

it->action) {

- DCHECK(it->specifics.HasExtension(sync_pb::password))

+ DCHECK(it->specifics.has_password())

<< "Password specifics data not present on delete!";

DCHECK(it->extra.get());

sync_api::ExtraPasswordChangeRecordData* extra =