chrome/browser/sync/engine/build_commit_command.cc - Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/build_commit_command.cc

Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fred's review Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/engine/apply_updates_command_unittest.cc ('k') | chrome/browser/sync/engine/clear_data_command_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/engine/build_commit_command.cc

diff --git a/chrome/browser/sync/engine/build_commit_command.cc b/chrome/browser/sync/engine/build_commit_command.cc

index 4655827ec31229c8137ac2d4afb5ba2080a1638f..06adac6271b767168998d6d27d5cfd7053d5007f 100644

--- a/chrome/browser/sync/engine/build_commit_command.cc

+++ b/chrome/browser/sync/engine/build_commit_command.cc

@@ -179,7 +179,7 @@ SyncerError BuildCommitCommand::ExecuteImpl(SyncSession* session) {

if (meta_entry.Get(IS_DEL)) {

sync_entry->set_deleted(true);

} else {

- if (meta_entry.Get(SPECIFICS).HasExtension(sync_pb::bookmark)) {

+ if (meta_entry.Get(SPECIFICS).has_bookmark()) {

// Common data in both new and old protocol.

const Id& prev_id = meta_entry.Get(syncable::PREV_ID);

string prev_id_string =