chrome/browser/extensions/app_notification_manager_sync_unittest.cc - Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_notification_manager_sync_unittest.cc

Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fred's review Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/app_notification_manager.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/app_notification_manager_sync_unittest.cc

diff --git a/chrome/browser/extensions/app_notification_manager_sync_unittest.cc b/chrome/browser/extensions/app_notification_manager_sync_unittest.cc

index 87770483f25d7f55828e6aaeba00414599f4d1a6..0f778f2e3976462cd6f9c36cf7afd75acebfbda1 100644

--- a/chrome/browser/extensions/app_notification_manager_sync_unittest.cc

+++ b/chrome/browser/extensions/app_notification_manager_sync_unittest.cc

@@ -9,6 +9,7 @@

#include "chrome/browser/extensions/app_notification.h"

#include "chrome/browser/extensions/app_notification_manager.h"

#include "chrome/browser/sync/protocol/app_notification_specifics.pb.h"

+#include "chrome/browser/sync/protocol/sync.pb.h"

#include "chrome/test/base/testing_profile.h"

#include "content/test/test_browser_thread.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -19,8 +20,7 @@ namespace {

// Extract notification guid from SyncData.

std::string GetGuid(const SyncData& sync_data) {

- return sync_data.GetSpecifics().GetExtension(

- sync_pb::app_notification).guid();

+ return sync_data.GetSpecifics().app_notification().guid();

}

// Dummy SyncChangeProcessor used to help review what SyncChanges are pushed

« no previous file with comments | « chrome/browser/extensions/app_notification_manager.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »