chrome/browser/sync/profile_sync_service_autofill_unittest.cc - Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nick's comment Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/internal_api/write_node.cc ('k') | chrome/browser/sync/profile_sync_service_preference_unittest.cc » ('j') | chrome/browser/sync/protocol/proto_value_conversions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

index 411a2192e1daa2e138da95336d11c755c05f121c..7c6d2cf7c3369bbcbe8debccc95439dc24015b81 100644

--- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

@@ -451,7 +451,7 @@ class ProfileSyncServiceAutofillTest : public AbstractProfileSyncServiceTest {

sync_pb::EntitySpecifics specifics;

AutocompleteSyncableService::WriteAutofillEntry(entry, &specifics);

sync_pb::AutofillSpecifics* autofill_specifics =

- specifics.MutableExtension(sync_pb::autofill);

+ specifics.mutable_autofill();

node.SetAutofillSpecifics(*autofill_specifics);

return true;

}

@@ -469,7 +469,7 @@ class ProfileSyncServiceAutofillTest : public AbstractProfileSyncServiceTest {

sync_pb::EntitySpecifics specifics;

AutofillProfileSyncableService::WriteAutofillProfile(profile, &specifics);

sync_pb::AutofillProfileSpecifics* profile_specifics =

- specifics.MutableExtension(sync_pb::autofill_profile);

+ specifics.mutable_autofill_profile();

node.SetAutofillProfileSpecifics(*profile_specifics);

return true;

}

@@ -660,8 +660,7 @@ class FakeServerUpdater : public base::RefCountedThreadSafe<FakeServerUpdater> {

}

sync_pb::EntitySpecifics entity_specifics;

- entity_specifics.MutableExtension(sync_pb::autofill)->

- CopyFrom(new_autofill);

+ entity_specifics.mutable_autofill()->CopyFrom(new_autofill);

{

// Tell main thread we've started