chrome/browser/sync/engine/verify_updates_command_unittest.cc - Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/verify_updates_command_unittest.cc

Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nick's comment Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/engine/syncer_util.cc ('k') | chrome/browser/sync/glue/password_change_processor.cc » ('j') | chrome/browser/sync/protocol/proto_value_conversions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/engine/verify_updates_command_unittest.cc

diff --git a/chrome/browser/sync/engine/verify_updates_command_unittest.cc b/chrome/browser/sync/engine/verify_updates_command_unittest.cc

index d3f20a4b8a798c8eecd49bb2f750626c303e3723..b207e6f048c7ba5676ee5b0a74c0cd951d6966f9 100644

--- a/chrome/browser/sync/engine/verify_updates_command_unittest.cc

+++ b/chrome/browser/sync/engine/verify_updates_command_unittest.cc

@@ -51,7 +51,7 @@ class VerifyUpdatesCommandTest : public SyncerCommandTest {

entry.Put(syncable::NON_UNIQUE_NAME, item_id);

entry.Put(syncable::PARENT_ID, Id::CreateFromServerId(parent_id));

sync_pb::EntitySpecifics default_specifics;

- AddDefaultExtensionValue(type, &default_specifics);

+ AddDefaultFieldValue(type, &default_specifics);

entry.Put(syncable::SERVER_SPECIFICS, default_specifics);

}

@@ -63,7 +63,7 @@ class VerifyUpdatesCommandTest : public SyncerCommandTest {

e->set_parent_id_string(parent);

e->set_non_unique_name("b1");

e->set_name("b1");

- AddDefaultExtensionValue(type, e->mutable_specifics());

+ AddDefaultFieldValue(type, e->mutable_specifics());

}

VerifyUpdatesCommand command_;