chrome/browser/sync/syncable/directory_backing_store.cc - Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/syncable/directory_backing_store.cc

Issue 9460047: sync: remove use of protobuf extensions in protocol to reduce static init overhead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix nigori access in testserver Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/protocol/typed_url_specifics.proto ('k') | chrome/browser/sync/syncable/directory_backing_store_unittest.cc » ('j') | net/tools/testserver/chromiumsync.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/syncable/directory_backing_store.cc

diff --git a/chrome/browser/sync/syncable/directory_backing_store.cc b/chrome/browser/sync/syncable/directory_backing_store.cc

index 65c3278ce4a41626dff9ec057146c388e420008f..9b79a7216f7685227ba6588da0dd0db67c2ccd13 100644

--- a/chrome/browser/sync/syncable/directory_backing_store.cc

+++ b/chrome/browser/sync/syncable/directory_backing_store.cc

@@ -680,7 +680,7 @@ void EncodeBookmarkURLAndFavicon(sql::Statement* old_value_query,

if (old_is_bookmark_object) {

sync_pb::BookmarkSpecifics* bookmark_data =

- mutable_new_value->MutableExtension(sync_pb::bookmark);

+ mutable_new_value->mutable_bookmark();

if (!old_is_dir) {

bookmark_data->set_url(old_url);

bookmark_data->set_favicon(old_favicon);