sync: remove use of protobuf extensions in protocol to reduce static init overhead.

chrome/browser/sync/syncable/directory_backing_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include <string>
 
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 1576 matching lines @@
   sql::Statement s(connection.GetUniqueStatement("SELECT non_unique_name,"
       "is_del, is_dir, id, specifics, server_specifics FROM metas "
       "WHERE metahandle = 2"));
   ASSERT_TRUE(s.Step());
   ASSERT_EQ("Deleted Item", s.ColumnString(0));
   ASSERT_TRUE(s.ColumnBool(1));
   ASSERT_FALSE(s.ColumnBool(2));
   ASSERT_EQ("s_ID_2", s.ColumnString(3));
   sync_pb::EntitySpecifics specifics;
   specifics.ParseFromArray(s.ColumnBlob(4), s.ColumnByteLength(4));
-  ASSERT_TRUE(specifics.HasExtension(sync_pb::bookmark));
-  ASSERT_EQ("http://www.google.com/",
-      specifics.GetExtension(sync_pb::bookmark).url());
-  ASSERT_EQ("AASGASGA", specifics.GetExtension(sync_pb::bookmark).favicon());
+  ASSERT_TRUE(specifics.has_bookmark());
+  ASSERT_EQ("http://www.google.com/", specifics.bookmark().url());
+  ASSERT_EQ("AASGASGA", specifics.bookmark().favicon());
   specifics.ParseFromArray(s.ColumnBlob(5), s.ColumnByteLength(5));
-  ASSERT_TRUE(specifics.HasExtension(sync_pb::bookmark));
-  ASSERT_EQ("http://www.google.com/2",
-      specifics.GetExtension(sync_pb::bookmark).url());
-  ASSERT_EQ("ASADGADGADG", specifics.GetExtension(sync_pb::bookmark).favicon());
+  ASSERT_TRUE(specifics.has_bookmark());
+  ASSERT_EQ("http://www.google.com/2", specifics.bookmark().url());
+  ASSERT_EQ("ASADGADGADG", specifics.bookmark().favicon());
   ASSERT_FALSE(s.Step());
 }
 
 TEST_F(DirectoryBackingStoreTest, MigrateVersion69To70) {
   SetUpVersion69Database();
 
   {
     sql::Connection connection;
     ASSERT_TRUE(connection.Open(GetDatabasePath()));
 
@@ skipping 437 matching lines @@
   MetahandlesIndex::iterator it = index.begin();
   ASSERT_TRUE(it != index.end());
   ASSERT_EQ(1, (*it)->ref(META_HANDLE));
   EXPECT_TRUE((*it)->ref(ID).IsRoot());
 
   ASSERT_TRUE(++it != index.end());
   ASSERT_EQ(6, (*it)->ref(META_HANDLE));
   EXPECT_TRUE((*it)->ref(IS_DIR));
   EXPECT_TRUE((*it)->ref(SERVER_IS_DIR));
   EXPECT_FALSE(
-      (*it)->ref(SPECIFICS).GetExtension(sync_pb::bookmark).has_url());
+      (*it)->ref(SPECIFICS).bookmark().has_url());
   EXPECT_FALSE(
-      (*it)->ref(SERVER_SPECIFICS).GetExtension(sync_pb::bookmark).has_url());
+      (*it)->ref(SERVER_SPECIFICS).bookmark().has_url());
   EXPECT_FALSE(
-      (*it)->ref(SPECIFICS).GetExtension(sync_pb::bookmark).has_favicon());
-  EXPECT_FALSE((*it)->ref(SERVER_SPECIFICS).
-      GetExtension(sync_pb::bookmark).has_favicon());
+      (*it)->ref(SPECIFICS).bookmark().has_favicon());
+  EXPECT_FALSE((*it)->ref(SERVER_SPECIFICS).bookmark().has_favicon());
 
   ASSERT_TRUE(++it != index.end());
   ASSERT_EQ(7, (*it)->ref(META_HANDLE));
   EXPECT_EQ("google_chrome", (*it)->ref(UNIQUE_SERVER_TAG));
-  EXPECT_FALSE((*it)->ref(SPECIFICS).HasExtension(sync_pb::bookmark));
-  EXPECT_FALSE((*it)->ref(SERVER_SPECIFICS).HasExtension(sync_pb::bookmark));
+  EXPECT_FALSE((*it)->ref(SPECIFICS).has_bookmark());
+  EXPECT_FALSE((*it)->ref(SERVER_SPECIFICS).has_bookmark());
 
   ASSERT_TRUE(++it != index.end());
   ASSERT_EQ(8, (*it)->ref(META_HANDLE));
   EXPECT_EQ("google_chrome_bookmarks", (*it)->ref(UNIQUE_SERVER_TAG));
-  EXPECT_TRUE((*it)->ref(SPECIFICS).HasExtension(sync_pb::bookmark));
-  EXPECT_TRUE((*it)->ref(SERVER_SPECIFICS).HasExtension(sync_pb::bookmark));
+  EXPECT_TRUE((*it)->ref(SPECIFICS).has_bookmark());
+  EXPECT_TRUE((*it)->ref(SERVER_SPECIFICS).has_bookmark());
 
   ASSERT_TRUE(++it != index.end());
   ASSERT_EQ(9, (*it)->ref(META_HANDLE));
   EXPECT_EQ("bookmark_bar", (*it)->ref(UNIQUE_SERVER_TAG));
-  EXPECT_TRUE((*it)->ref(SPECIFICS).HasExtension(sync_pb::bookmark));
-  EXPECT_TRUE((*it)->ref(SERVER_SPECIFICS).HasExtension(sync_pb::bookmark));
+  EXPECT_TRUE((*it)->ref(SPECIFICS).has_bookmark());
+  EXPECT_TRUE((*it)->ref(SERVER_SPECIFICS).has_bookmark());
 
   ASSERT_TRUE(++it != index.end());
   ASSERT_EQ(10, (*it)->ref(META_HANDLE));
   EXPECT_FALSE((*it)->ref(IS_DEL));
-  EXPECT_TRUE((*it)->ref(SPECIFICS).HasExtension(sync_pb::bookmark));
-  EXPECT_TRUE((*it)->ref(SERVER_SPECIFICS).HasExtension(sync_pb::bookmark));
-  EXPECT_FALSE((*it)->ref(SPECIFICS).GetExtension(sync_pb::bookmark).has_url());
+  EXPECT_TRUE((*it)->ref(SPECIFICS).has_bookmark());
+  EXPECT_TRUE((*it)->ref(SERVER_SPECIFICS).has_bookmark());
+  EXPECT_FALSE((*it)->ref(SPECIFICS).bookmark().has_url());
   EXPECT_FALSE(
-      (*it)->ref(SPECIFICS).GetExtension(sync_pb::bookmark).has_favicon());
+      (*it)->ref(SPECIFICS).bookmark().has_favicon());
   EXPECT_FALSE(
-      (*it)->ref(SERVER_SPECIFICS).GetExtension(sync_pb::bookmark).has_url());
-  EXPECT_FALSE((*it)->ref(SERVER_SPECIFICS).
-      GetExtension(sync_pb::bookmark).has_favicon());
+      (*it)->ref(SERVER_SPECIFICS).bookmark().has_url());
+  EXPECT_FALSE((*it)->ref(SERVER_SPECIFICS).bookmark().has_favicon());
   EXPECT_EQ("other_bookmarks", (*it)->ref(UNIQUE_SERVER_TAG));
   EXPECT_EQ("Other Bookmarks", (*it)->ref(NON_UNIQUE_NAME));
   EXPECT_EQ("Other Bookmarks", (*it)->ref(SERVER_NON_UNIQUE_NAME));
 
   ASSERT_TRUE(++it != index.end());
   ASSERT_EQ(11, (*it)->ref(META_HANDLE));
   EXPECT_FALSE((*it)->ref(IS_DEL));
   EXPECT_FALSE((*it)->ref(IS_DIR));
-  EXPECT_TRUE((*it)->ref(SPECIFICS).HasExtension(sync_pb::bookmark));
-  EXPECT_TRUE((*it)->ref(SERVER_SPECIFICS).HasExtension(sync_pb::bookmark));
+  EXPECT_TRUE((*it)->ref(SPECIFICS).has_bookmark());
+  EXPECT_TRUE((*it)->ref(SERVER_SPECIFICS).has_bookmark());
   EXPECT_EQ("http://dev.chromium.org/",
-    (*it)->ref(SPECIFICS).GetExtension(sync_pb::bookmark).url());
+      (*it)->ref(SPECIFICS).bookmark().url());
   EXPECT_EQ("AGATWA",
-    (*it)->ref(SPECIFICS).GetExtension(sync_pb::bookmark).favicon());
+      (*it)->ref(SPECIFICS).bookmark().favicon());
   EXPECT_EQ("http://dev.chromium.org/other",
-    (*it)->ref(SERVER_SPECIFICS).GetExtension(sync_pb::bookmark).url());
+      (*it)->ref(SERVER_SPECIFICS).bookmark().url());
   EXPECT_EQ("AFAGVASF",
-    (*it)->ref(SERVER_SPECIFICS).GetExtension(sync_pb::bookmark).favicon());
+      (*it)->ref(SERVER_SPECIFICS).bookmark().favicon());
   EXPECT_EQ("", (*it)->ref(UNIQUE_SERVER_TAG));
   EXPECT_EQ("Home (The Chromium Projects)", (*it)->ref(NON_UNIQUE_NAME));
   EXPECT_EQ("Home (The Chromium Projects)", (*it)->ref(SERVER_NON_UNIQUE_NAME));
 
   ASSERT_TRUE(++it != index.end());
   ASSERT_EQ(12, (*it)->ref(META_HANDLE));
   EXPECT_FALSE((*it)->ref(IS_DEL));
   EXPECT_TRUE((*it)->ref(IS_DIR));
   EXPECT_EQ("Extra Bookmarks", (*it)->ref(NON_UNIQUE_NAME));
   EXPECT_EQ("Extra Bookmarks", (*it)->ref(SERVER_NON_UNIQUE_NAME));
-  EXPECT_TRUE((*it)->ref(SPECIFICS).HasExtension(sync_pb::bookmark));
-  EXPECT_TRUE((*it)->ref(SERVER_SPECIFICS).HasExtension(sync_pb::bookmark));
+  EXPECT_TRUE((*it)->ref(SPECIFICS).has_bookmark());
+  EXPECT_TRUE((*it)->ref(SERVER_SPECIFICS).has_bookmark());
   EXPECT_FALSE(
-      (*it)->ref(SPECIFICS).GetExtension(sync_pb::bookmark).has_url());
+      (*it)->ref(SPECIFICS).bookmark().has_url());
   EXPECT_FALSE(
-      (*it)->ref(SERVER_SPECIFICS).GetExtension(sync_pb::bookmark).has_url());
+      (*it)->ref(SERVER_SPECIFICS).bookmark().has_url());
   EXPECT_FALSE(
-      (*it)->ref(SPECIFICS).GetExtension(sync_pb::bookmark).has_favicon());
-  EXPECT_FALSE((*it)->ref(SERVER_SPECIFICS).
-      GetExtension(sync_pb::bookmark).has_favicon());
+      (*it)->ref(SPECIFICS).bookmark().has_favicon());
+  EXPECT_FALSE((*it)->ref(SERVER_SPECIFICS).bookmark().has_favicon());
 
   ASSERT_TRUE(++it != index.end());
   ASSERT_EQ(13, (*it)->ref(META_HANDLE));
 
   ASSERT_TRUE(++it != index.end());
   ASSERT_EQ(14, (*it)->ref(META_HANDLE));
 
   ASSERT_TRUE(++it == index.end());
 }
 
@@ skipping 76 matching lines @@
   const std::string& guid1 = DirectoryBackingStore::GenerateCacheGUID();
   const std::string& guid2 = DirectoryBackingStore::GenerateCacheGUID();
   EXPECT_EQ(24U, guid1.size());
   EXPECT_EQ(24U, guid2.size());
   // In theory this test can fail, but it won't before the universe
   // dies of heat death.
   EXPECT_NE(guid1, guid2);
 }
 
 }  // namespace syncable