sync: remove use of protobuf extensions in protocol to reduce static init overhead.

chrome/browser/extensions/app_notification_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/app_notification_manager.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/file_path.h"
 #include "base/location.h"
 #include "base/metrics/histogram.h"
 #include "base/perftimer.h"
 #include "base/stl_util.h"
 #include "base/time.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/protocol/app_notification_specifics.pb.h"
+#include "chrome/browser/sync/protocol/sync.pb.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/notification_service.h"
 
 using content::BrowserThread;
 
 typedef std::map<std::string, SyncData> SyncDataMap;
 
 namespace {
 
@@ skipping 22 matching lines @@
   AppNotificationList::iterator iter = std::find_if(
       list->begin(), list->end(), std::bind2nd(GuidComparator(), guid));
   if (iter != list->end())
     list->erase(iter);
 }
 
 void PopulateGuidToSyncDataMap(const SyncDataList& sync_data,
                                SyncDataMap* data_map) {
   for (SyncDataList::const_iterator iter = sync_data.begin();
        iter != sync_data.end(); ++iter) {
-    (*data_map)[iter->GetSpecifics().GetExtension(
-        sync_pb::app_notification).guid()] = *iter;
+    (*data_map)[iter->GetSpecifics().app_notification().guid()] = *iter;
   }
 }
 }  // namespace
 
 const unsigned int AppNotificationManager::kMaxNotificationPerApp = 5;
 
 AppNotificationManager::AppNotificationManager(Profile* profile)
     : profile_(profile),
       sync_processor_(NULL),
       models_associated_(false),
@@ skipping 437 matching lines @@
       content::Source<Profile>(profile_),
       content::Details<const std::string>(&extension_id));
 }
 
 // static
 SyncData AppNotificationManager::CreateSyncDataFromNotification(
     const AppNotification& notification) {
   DCHECK(!notification.is_local());
   sync_pb::EntitySpecifics specifics;
   sync_pb::AppNotification* notif_specifics =
-      specifics.MutableExtension(sync_pb::app_notification);
+      specifics.mutable_app_notification();
   notif_specifics->set_app_id(notification.extension_id());
   notif_specifics->set_creation_timestamp_ms(
       notification.creation_time().ToInternalValue());
   notif_specifics->set_body_text(notification.body());
   notif_specifics->set_guid(notification.guid());
   notif_specifics->set_link_text(notification.link_text());
   notif_specifics->set_link_url(notification.link_url().spec());
   notif_specifics->set_title(notification.title());
   return SyncData::CreateLocalData(
       notif_specifics->guid(), notif_specifics->app_id(), specifics);
 }
 
 // static
 AppNotification* AppNotificationManager::CreateNotificationFromSyncData(
     const SyncData& sync_data) {
   sync_pb::AppNotification specifics =
-      sync_data.GetSpecifics().GetExtension(sync_pb::app_notification);
+      sync_data.GetSpecifics().app_notification();
 
   // Check for mandatory fields.
   if (!specifics.has_app_id() || !specifics.has_guid() ||
       !specifics.has_title() || !specifics.has_body_text() ||
       !specifics.has_creation_timestamp_ms()) {
     return NULL;
   }
 
   AppNotification* notification = new AppNotification(
       false, base::Time::FromInternalValue(specifics.creation_timestamp_ms()),
       specifics.guid(), specifics.app_id(),
       specifics.title(), specifics.body_text());
   if (specifics.has_link_text())
     notification->set_link_text(specifics.link_text());
   if (specifics.has_link_url())
     notification->set_link_url(GURL(specifics.link_url()));
   return notification;
 }